From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hoeppner@linux.ibm.com, vigneshr@ti.com, yi.zhang@huawei.com,
linux-kernel@vger.kernel.org, gfs2@lists.linux.dev, clm@fb.com,
adilger.kernel@dilger.ca, miquel.raynal@bootlin.com,
agordeev@linux.ibm.com, linux-s390@vger.kernel.org,
linux-nilfs@vger.kernel.org, agruenba@redhat.com,
linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org,
richard@nod.at, willy@infradead.org, hch@infradead.org,
xen-devel@lists.xenproject.org, yukuai3@huawei.com,
linux-ext4@vger.kernel.org, jejb@linux.ibm.com,
p.raghav@samsung.com, gor@linux.ibm.com, hca@linux.ibm.com,
joern@lazybastard.org, josef@toxicpanda.com, colyli@suse.de,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
dlemoal@kernel.org, viro@zeniv.linux.org.uk, dchinner@redhat.com,
dsterba@suse.com, ming.lei@redhat.com, konishi.ryusuke@gmail.com,
axboe@kernel.dk, brauner@kernel.org, tytso@mit.edu,
martin.petersen@oracle.com, nico@fluxnic.net,
linux-erofs@lists.ozlabs.org, yangerkun@huawei.com,
linux@weissschuh.net, kent.overstre et@gmail.com, hare@suse.de,
jack@suse.com, linux-fsdevel@vger.kernel.org,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
roger.pau@citrix.com, min15.li@samsung.com,
linux-btrfs@vger.kernel.org, sth@linux.ibm.com
Subject: Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device
Date: Sun, 26 Nov 2023 23:21:29 -0800 [thread overview]
Message-ID: <ZWRDeQ4K8BiYnV+X@infradead.org> (raw)
In-Reply-To: <20231127062116.2355129-2-yukuai1@huaweicloud.com>
On Mon, Nov 27, 2023 at 02:21:01PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> block_devcie is allocated from bdev_alloc() by bdev_alloc_inode(), and
> currently block_device contains a pointer that point to the address of
> inode, while such inode is allocated together:
This is going the wrong way. Nothing outside of core block layer code
should ever directly use the bdev inode. We've been rather sloppy
and added a lot of direct reference to it, but they really need to
go away and be replaced with well defined high level operation on
struct block_device. Once that is done we can remove the bd_inode
pointer, but replacing it with something that pokes even more deeply
into bdev internals is a bad idea.
next prev parent reply other threads:[~2023-11-27 7:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 6:21 [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 01/16] block: add a new helper to get inode " Yu Kuai
2023-11-27 7:21 ` Christoph Hellwig [this message]
2023-11-27 13:07 ` Yu Kuai
2023-11-27 16:32 ` Christoph Hellwig
2023-11-28 1:35 ` Yu Kuai
2023-11-28 5:48 ` Christoph Hellwig
2023-11-27 6:21 ` [PATCH block/for-next v2 02/16] xen/blkback: use " Yu Kuai
2023-11-28 10:05 ` Roger Pau Monné via Linux-erofs
2023-11-27 6:21 ` [PATCH block/for-next v2 03/16] bcache: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 04/16] mtd: block2mtd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 05/16] s390/dasd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 06/16] scsicam: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 07/16] bcachefs: " Yu Kuai
2023-11-27 6:49 ` Kent Overstreet
2023-11-27 7:09 ` Damien Le Moal
2023-11-27 7:24 ` Kent Overstreet
2023-11-27 7:52 ` Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 08/16] btrfs: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 09/16] cramfs: " Yu Kuai
2023-11-27 6:47 ` [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWRDeQ4K8BiYnV+X@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=agordeev@linux.ibm.com \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dchinner@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=joern@lazybastard.org \
--cc=josef@toxicpanda.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=nico@fluxnic.net \
--cc=p.raghav@samsung.com \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox