From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DF86C47DAF for ; Mon, 22 Jan 2024 16:10:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=bAHg37/D; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TJZv259wLz3c1C for ; Tue, 23 Jan 2024 03:10:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=bAHg37/D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=willy@infradead.org; receiver=lists.ozlabs.org) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TJZtv2rCQz2yst for ; Tue, 23 Jan 2024 03:10:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NGNHyrHMg5T+Qh7WpIiamACVfA9Z4Rcr6JKQhuA9VEY=; b=bAHg37/DgOA2D7Nup2N9IoSCUf RYBdsFsEU0xkski0IK2yvU1A2OMrf/qhwna0hlIEwWl69adYPIHIu53ORHNeF2VBh5Hg6YqXlDLij QgT/abpxa9Ic03QJaHTpi1JbsPKKSfAD09GSoo5WzRD6w09XhsCKb33KdFEtAaiQroP+/MBSczuBJ PUqlXM14wca8GyUxdWtL6h281dGgW485gjFNKwYDyeOQmtaqKuC5cFXaOk2jp+fQu2XsCOZRo+WJs UhFEoChHuXUqVFkeJ67BcBHkeCQZslkJMYJKeIyQiOigfY3G+09Cq0PK3aHfIXU01a0Vs85+b2vdc ADEmH24g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rRws8-00000000Mhy-0VRc; Mon, 22 Jan 2024 16:10:04 +0000 Date: Mon, 22 Jan 2024 16:10:04 +0000 From: Matthew Wilcox To: Jeff Layton Subject: Re: [PATCH 01/10] netfs: Don't use certain internal folio_*() functions Message-ID: References: <20240122123845.3822570-1-dhowells@redhat.com> <20240122123845.3822570-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, David Howells , linux-mm@kvack.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, ceph-devel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-afs@lists.infradead.org, Christian Brauner Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Mon, Jan 22, 2024 at 10:38:58AM -0500, Jeff Layton wrote: > On Mon, 2024-01-22 at 12:38 +0000, David Howells wrote: > > Filesystems should not be using folio->index not folio_index(folio) and > > I think you mean "should be" here. Also these are not internal functions! They're just functions that filesystems shouldn't be using because filesystems are only exposed to their own folios. The erofs patch used the word "unnecessary", which I like better (2b872b0f466d).