Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Noboru Asai <asai@sijam.com>
Cc: hsiangkao@linux.alibaba.com, zhaoyifan@sjtu.edu.cn,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 1/3] erofs-utils: determine the [un]compressed data block is inline or not early
Date: Thu, 18 Apr 2024 15:37:18 +0800	[thread overview]
Message-ID: <ZiDNrgdW5nJcJs2H@debian> (raw)
In-Reply-To: <20240418055231.146591-1-asai@sijam.com>

Hi Noboru,

On Thu, Apr 18, 2024 at 02:52:29PM +0900, Noboru Asai wrote:
> Introducing erofs_get_inodesize function and erofs_get_lowest_offset function,
> we can determine the [un]compressed data block is inline or not before
> executing z_erofs_merge_segment function. It enable the following,
> 
> * skip the redundant write for ztailpacking block.
> * simplify erofs_prepare_inode_buffer function. (remove handling ENOSPC error)
> 
> Signed-off-by: Noboru Asai <asai@sijam.com>

I appreciate and thanks for your effort and time.

Yet I tend to avoid assuming if the inline is ok or not before
prepare_inode_buffer() since it will be free for space allocator
to decide inline or not at that time.

So personally I still would like to write a final compressed
index for inline fallback.

I will fix this issue myself later (it should be just a small
patch to fix this). 

Thanks for your effort on this issue again!

Thanks,
Gao Xiang


  parent reply	other threads:[~2024-04-18  7:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  5:52 [PATCH 1/3] erofs-utils: determine the [un]compressed data block is inline or not early Noboru Asai
2024-04-18  5:52 ` [PATCH 2/3] erofs-utils: skip the redundant write for ztailpacking block Noboru Asai
2024-04-18  5:52 ` [PATCH 3/3] erofs-utils: allow blkaddr == EROFS_NULL_ADDR for zpacking in write_compacted_indexes() Noboru Asai
2024-04-18  7:37 ` Gao Xiang [this message]
2024-04-19  6:19   ` [PATCH 1/3] erofs-utils: determine the [un]compressed data block is inline or not early Noboru Asai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZiDNrgdW5nJcJs2H@debian \
    --to=xiang@kernel.org \
    --cc=asai@sijam.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=zhaoyifan@sjtu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox