Re: [PATCH] erofs-utils: lib: relax erofs_write_device_table() device table check

[Jonathan Calmels <jcalmels@nvidia.com>]

On Thu, Feb 12, 2026 at 05:13:31PM +0800, Gao Xiang wrote:
> External email: Use caution opening links or attachments
> 
> 
> Hi Jonathan,
> 
> On 2026/2/12 08:13, Jonathan Calmels wrote:
> > Avoid returning an error in erofs_write_device_table()
> > if a new device slot table hasn't been allocated.
> > Rationale is to allow erofs_importer_flush_all() to succeed when
> > dealing with images with pre-existing device slots.
> > 
> > Signed-off-by: Jonathan Calmels <jcalmels@nvidia.com>
> 
> Thanks for the patch, could you elaborate how to use this?
> 
> A detailed command line usage would be better.
> 
> (Also honestly I will try to release erofs-utils 1.9 in
>  a few days for the upcoming ubuntu LTS, so I have to
>  finish erofs fsmerge feature for compression layout
>  after the version is released...)
> 
> Thanks,
> Gao Xiang

I'm relying on the library not the CLI, I think the equivalent would be:

mkfs.erofs -Efragments,noinline_data,ztailpacking a.erofs a/
mkfs.erofs -Efragments,noinline_data,ztailpacking b.erofs b/
mkfs.erofs merged.erofs a.erofs b.erofs
mkfs.erofs --incremental=data merged.erofs c/

It does seem to work as expected after the patch, but let me know if I
missed anything.

Thanks

> > ---
> >   lib/super.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/super.c b/lib/super.c
> > index a203f96..d38396f 100644
> > --- a/lib/super.c
> > +++ b/lib/super.c
> > @@ -392,7 +392,7 @@ int erofs_write_device_table(struct erofs_sb_info *sbi)
> >       if (!sbi->extra_devices)
> >               goto out;
> >       if (!bh)
> > -             return -EINVAL;
> > +             goto out;
> > 
> >       pos = erofs_btell(bh, false);
> >       if (pos == EROFS_NULL_ADDR) {
>