Re: [PATCH] erofs-utils: lib: relax erofs_write_device_table() device table check

[Gao Xiang <xiang@kernel.org>]

On Thu, Feb 12, 2026 at 09:00:18AM -0800, Jonathan Calmels wrote:
> On Thu, Feb 12, 2026 at 05:13:31PM +0800, Gao Xiang wrote:
> > External email: Use caution opening links or attachments
> > 
> > Thanks for the patch, could you elaborate how to use this?

...

> 
> I'm relying on the library not the CLI, I think the equivalent would be:
> 
> mkfs.erofs -Efragments,noinline_data,ztailpacking a.erofs a/
> mkfs.erofs -Efragments,noinline_data,ztailpacking b.erofs b/
> mkfs.erofs merged.erofs a.erofs b.erofs
> mkfs.erofs --incremental=data merged.erofs c/

Could you document this in the commit message?

I think it makes sense, also lacks of `-z`
if `-Efragments` is specified.

> 
> > > diff --git a/lib/super.c b/lib/super.c
> > > index a203f96..d38396f 100644
> > > --- a/lib/super.c
> > > +++ b/lib/super.c
> > > @@ -392,7 +392,7 @@ int erofs_write_device_table(struct erofs_sb_info *sbi)
> > >       if (!sbi->extra_devices)
> > >               goto out;
> > >       if (!bh)
> > > -             return -EINVAL;
> > > +             goto out;


How about updating to the following instead for now?

        if (!sbi->extra_devices)
                goto out;
-       if (!bh)
+       if (!bh) {
+               if (erofs_sb_has_device_table(sbi))
+                       return 0;
                return -EINVAL;
+       }

        pos = erofs_btell(bh, false);
        if (pos == NULL_ADDR_UL) {


Thanks,
Gao Xiang

> > > 
> > >       pos = erofs_btell(bh, false);
> > >       if (pos == EROFS_NULL_ADDR) {
> >