From: Gao Xiang <xiang@kernel.org>
To: Utkal Singh <singhutkal015@gmail.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org,
yifan.yfzhao@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] erofs: validate h_shared_count in erofs_init_inode_xattrs()
Date: Wed, 18 Mar 2026 01:07:53 +0800 [thread overview]
Message-ID: <abmKacsG6m5oAsFm@debian> (raw)
In-Reply-To: <CAGSu4WOop42Dh_7kni3uK5fsjB4zDRkqvVWyZ=+AqbXoEACCsw@mail.gmail.com>
On Tue, Mar 17, 2026 at 10:29:00PM +0530, Utkal Singh wrote:
> >
> > Hi Gao,
> >
> > Sorry about this. The mismatch between the commit message and the code
> > slipped through when I revised the patch — I updated the implementation to
> > use sizeof(__le32) but forgot to update the commit message to match. The
> > changelog was also wrong (v2 mislabeled as "initial").
Sorry, honestly I'm skeptical about it, because your v2 already uses
__le32:
https://lore.kernel.org/r/20260317152439.5738-1-singhutkal015@gmail.com
And I think your v2 is almost fine, I will revise a bit manually.
> >
> > I wrote this myself, just didn't review carefully enough before resending.
> > I'll be more thorough going forward.
> >
> > Will send a clean v4 shortly.
Please don't resend anymore, it seems the mailing list is flooded
with your patches, and most versions are meaningless.
Thanks,
Gao Xiang
> >
> > Thanks, Utkal
> >
next prev parent reply other threads:[~2026-03-17 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 15:24 [PATCH v2] erofs: harden h_shared_count in erofs_init_inode_xattrs() Utkal Singh
2026-03-17 16:10 ` Gao Xiang
2026-03-17 16:41 ` [PATCH v3] erofs: validate " Utkal Singh
2026-03-17 16:48 ` Gao Xiang
2026-03-17 16:53 ` Gao Xiang
2026-03-17 16:59 ` Utkal Singh
2026-03-17 17:07 ` Gao Xiang [this message]
2026-03-18 6:08 ` [PATCH v2] erofs: harden " Chao Yu
2026-03-18 7:39 ` Utkal Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abmKacsG6m5oAsFm@debian \
--to=xiang@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhutkal015@gmail.com \
--cc=yifan.yfzhao@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox