From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 472E2CD342F for ; Fri, 8 May 2026 08:21:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gBhs93Yd1z2xdb; Fri, 08 May 2026 18:21:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:7c80:54:3::133" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778228461; cv=none; b=T50lRgdJXn22M6l5FJ1gRPCFnZ4Y4Jmx77YkasyfKygi7iVa4qfi0esZQCh06LcYQ93C87w2AMprL3E2L1YsQOAxQfoiDQIvmltqurISXnP3q49DK1nD529dZ0VWrJGzAJV31HIKLqxo9Ye7bHQS2sDrUhf8zAgadPBk5+2+RUxxpTumwXxhKWaybj48qS8pRzZQsBH9uiqCBjRfETLr2zzE+HAgYOFaS877Vcge792Y/KgbNpDK9DBxv/V/6XsAmNo7Fx0dL4cUIYX11sV50guXljNPMwL4UL5qdQbXgQoJ6PD9Eob7Aa6/jiVpcf2BBY5wTD8iqLaAQqzdomt8EA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778228461; c=relaxed/relaxed; bh=Zkisq+nZ9+CHwylgMN2ygPINVVeeO6D8/0fnAwpndjo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lmZYAaCEq3lm6pOXV//yX9opzXlk5p3npImT5VjvQMwWYRxANxXp4MqGdUkEZR087njCMG3HD0CLkKSY7FA7mEaFf0VHyhU76+kfetqWrDkhb8Yuj7jdOxmeyzJ3hUYb/pYpI/+hmuFRi5oeGs0D/6Q6+C6N4BqhLu1Nck/pEcM7Vz+meocr6n5VwtibYx/jhxEWGtSaMfyRKbNNfoOMCM/tFnGFhgx8HuLAwEefwrIjDdEq3JjYTaQziTqsETsjMB1436HGSWFMNWY6cnGlK+MGL7ueU5i4hq4TWLnfYt5ljS5djMLHWMD3TuBq0LR4BM7LQ7XmTA5GL069S0b+8w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=infradead.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I/5Nm4wV; dkim-atps=neutral; spf=none (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+b3031b5f6a3880ed22fb+8293+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I/5Nm4wV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+b3031b5f6a3880ed22fb+8293+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gBhs34Pmcz2x9N for ; Fri, 08 May 2026 18:20:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Zkisq+nZ9+CHwylgMN2ygPINVVeeO6D8/0fnAwpndjo=; b=I/5Nm4wV3PRDZP/D/AqkSSGw4N EsW/0ty3dksH3teSQv6mp0d+2EwhighKdvq6fZINzN6bLB7Kp+jhtDosteYgpT1SGjMFrricSHpSn CaUnJuuxhkVmGf4ExRjvfHuqNmMujXvbgOUbugoaZvx9WDJyDsEBJneCYi+59El79kA/K+tgL88t7 frB7P6NA4FHnqGu79MSXjDK+YzuficgPUzCAt/YuyLWLE5M6DGxWZGIt4kQdO/E004Yz4qCs828GB KijyWHAPeuFNrETJhuKbzcCvk9HwnI1iHBQhJuQ4K3w5ykRNBLVymd2DemjKnG33++WlqZk/o9CDK 0pAaC0VA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLGS1-00000005ylP-3jcF; Fri, 08 May 2026 08:20:49 +0000 Date: Fri, 8 May 2026 01:20:49 -0700 From: Christoph Hellwig To: Gao Xiang Cc: linux-erofs@lists.ozlabs.org, Chao Yu , LKML , oliver.yang@linux.alibaba.com, Carlos Llamas , Sandeep Dhavale , Tatsuyuki Ishi , Christian Brauner , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] erofs: use the opener's credential when verifing metadata accesses Message-ID: References: <20260505155615.2719500-1-hsiangkao@linux.alibaba.com> X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505155615.2719500-1-hsiangkao@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, May 05, 2026 at 11:56:15PM +0800, Gao Xiang wrote: > Similar to commit 905eeb2b7c33 ("erofs: impersonate the opener's > credentials when accessing backing file"), rw_verify_area() needs > the same too. Two things here: - rw_verify_area is a helper for use inside the VFS and file system read/write method implementation. Erofs as a user of the VFS should not use it at all. - using the opener credentials when accessing the backing file seems wrong. The entity accessing it is the file system, so it should have system or mounter credentials, not that of someone causing metadata / fs data access. And this applies to all access by a file system backed by a backing file.