Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Gao Xiang" <xiang@kernel.org>,
	"Michael Bommarito" <michael.bommarito@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"SJ Park" <sj@kernel.org>,
	"Gao Xiang" <hsiangkao@linux.alibaba.com>,
	"Yue Hu" <zbestahu@gmail.com>,
	"Jeffle Xu" <jefflexu@linux.alibaba.com>,
	"Sandeep Dhavale" <dhavale@google.com>,
	"Chunhai Guo" <guochunhai@vivo.com>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	"Chao Yu" <chao@kernel.org>,
	"David Hildenbrand" <david@redhat.com>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v3] erofs: cap LZMA stream pool size
Date: Sat, 15 Aug 2026 02:26:27 +0800	[thread overview]
Message-ID: <an9d0zxE5J8txxf6@XiangdeMacBook-Pro.local> (raw)
In-Reply-To: <5825b5c2-06b3-4358-91b0-d7bf437528a3@roeck-us.net>

Hi Guenter,

On Wed, Aug 12, 2026 at 07:25:50AM -0700, Guenter Roeck wrote:

...

> > > 
> > > Thank you, that seems to work (despite still seeing the warning on m68k,
> > > as NR_CPUS does not exist).
> > > 
> > 
> > ...
> > 
> > > 
> > >        $ make ARCH=m68k allmodconfig
> > >       fs/erofs/Kconfig:137:warning: range is invalid
> > > 
> > >   Warning...
> > > 
> > 
> > Yes, other arches shouldn't have the warning because I think other
> > arches (including microblaze) defines NR_CPUS in Kconfig, except m68k.
> > 
> 
> That is not entirely true. openrisc only has it if SMP=y. But it still
> does not generate the warning for some reason.
> 

I looked into the documentation a bit
(https://docs.kernel.org/kbuild/kconfig-language.html), especially the
following parts:

 - type definition: “bool”/”tristate”/”string”/”hex”/”int” ...
 - input prompt: “prompt” <prompt> [“if” <expr>] ...
     and "If a prompt is not present, the config option is
          a non-visible symbol, ..."

 - dependencies: “depends on” <expr> [“if” <expr>] ...
 - Menu dependencies ..

and I think that is true, taking openrisc for example:

config NR_CPUS
        int "Maximum number of CPUs (2-32)"
        range 2 32
        depends on SMP
        default "2"

which can be transformed into

config NR_CPUS
        int
	prompt "Maximum number of CPUs (2-32)"
	range 2 32
	depends on SMP
        default "2"

which can be then transformed into

config NR_CPUS
        int
	prompt "Maximum number of CPUs (2-32)" if SMP
	range 2 32 if SMP
        default "2" if SMP

so if `SMP=n`, it's equivalent to

config NR_CPUS
        int

so NR_CPUS symbol is still there I think (and its value is 0.)

Thanks,
Gao Xiang


  reply	other threads:[~2026-08-14 18:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 11:47 [PATCH v3] erofs: cap LZMA stream pool size Michael Bommarito
2026-07-17  3:43 ` Gao Xiang
2026-07-21  3:44   ` Gao Xiang
2026-07-28  3:46     ` SJ Park
2026-07-28  6:31       ` Gao Xiang
2026-07-28  6:54         ` SJ Park
2026-08-03  8:09           ` Geert Uytterhoeven
2026-08-03  9:12             ` Uwe Kleine-König
2026-08-11 19:27               ` Geert Uytterhoeven
2026-08-11 19:35                 ` Guenter Roeck
2026-08-11 19:37                   ` Michael Bommarito
2026-08-11 23:36                     ` Gao Xiang
2026-08-12  9:30                       ` Geert Uytterhoeven
2026-08-12 10:54                         ` Gao Xiang
2026-08-12 11:28                           ` Geert Uytterhoeven
2026-08-12 13:11                             ` [PATCH] erofs: fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms Gao Xiang
2026-08-12 13:34                               ` Geert Uytterhoeven
2026-08-12 14:13                                 ` Gao Xiang
2026-08-12 14:21                               ` SJ Park
2026-08-17  7:32                               ` Geert Uytterhoeven
2026-08-17  7:48                                 ` Gao Xiang
2026-08-17  8:05                                   ` Geert Uytterhoeven
2026-08-17  8:09                                     ` Gao Xiang
2026-08-17  8:43                                       ` Geert Uytterhoeven
2026-08-17  9:04                                         ` Gao Xiang
2026-08-17  9:21                                           ` Geert Uytterhoeven
2026-08-17  9:47                                             ` Gao Xiang
2026-08-17 10:06                                               ` Gao Xiang
2026-08-20 10:04                                               ` Geert Uytterhoeven
2026-08-12 14:25                           ` [PATCH v3] erofs: cap LZMA stream pool size Guenter Roeck
2026-08-14 18:26                             ` Gao Xiang [this message]
2026-08-14 18:44                               ` Guenter Roeck
2026-08-14 18:50                                 ` Gao Xiang
2026-08-14 19:05                                   ` Guenter Roeck
2026-08-15 11:41                                 ` Geert Uytterhoeven
2026-08-15 13:31                                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an9d0zxE5J8txxf6@XiangdeMacBook-Pro.local \
    --to=xiang@kernel.org \
    --cc=chao@kernel.org \
    --cc=david@redhat.com \
    --cc=dhavale@google.com \
    --cc=geert@linux-m68k.org \
    --cc=guochunhai@vivo.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=michael.bommarito@gmail.com \
    --cc=sj@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox