Re: [PATCH v5 1/2] fs: rename vfs_get_super() to get_tree_super() and export it

[Gao Xiang <xiang@kernel.org>]

Hi Christian,

On Tue, Aug 25, 2026 at 02:32:48PM +0200, Christian Brauner wrote:
> On Tue, Aug 11, 2026 at 11:44:20PM +0800, Gao Xiang wrote:
> > (+ cc vfs maintainers)
> > 
> > Hi,
> > 
> > On Tue, Aug 11, 2026 at 09:10:50AM +0200, Giuseppe Scrivano wrote:
> > > vfs_get_super() already implements the common get_tree pattern of
> > > looking up an existing superblock via a test callback and initialising
> > > a new one with fill_super otherwise, but it is private to fs/super.c
> > > and only reachable through the get_tree_nodev()/get_tree_single()/
> > > get_tree_keyed() wrappers, none of which let a filesystem supply its
> > > own test callback.
> > > 
> > > Rename it to get_tree_super() and export it so filesystems that need a
> > > custom superblock matching policy can reuse it directly instead of
> > > open-coding sget_fc() + fill_super().  No functional change.
> > > 
> > > This is a preparatory fix for the next patch.
> > > 
> > > Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
> > 
> > With the new vfs_get_super() helper, it seems much cleaner compared
> > to the previous versions.
> 
> I'll add this patch to the vfs-7.3.super tree post -rc1 and then you can
> pull it in. Thanks!

I guess you meant vfs-7.4.super? If yes that would be fine, I'm willing
to land this feature for 7.4 too.

Thanks,
Gao Xiang

>