Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Pitt <martin@amutable.com>
To: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 3/3] erofs-utils: tests: check that the xattr layout is order-independent
Date: Wed, 26 Aug 2026 21:18:47 +0200	[thread overview]
Message-ID: <ao88F-F9wTDhKjvI@piware.de> (raw)
In-Reply-To: <20260804033214.211267-4-martin@amutable.com>

Hello again,

Martin Pitt [2026-08-04  5:32 +0200]:
> b260119b8edb ("erofs-utils: mkfs: emit an inode's xattrs in a canonical
> order") made the layout independent of the order listxattr(2) reports an
> inode's attributes in. Cover it: stage the same tree twice with the same
> attributes set in opposite order, and compare the two images. The names
> differ in length and share prefixes, so a subtly wrong comparison cannot
> order them correctly by accident.

I see my first [1] and second [2] preparatory patch made it into the tree
[3][4], but not this third one (and the main test).

Do you want me to explain or change anything, or did it simply fell through the
cracks?

Thank you!

Martin

[1] https://lore.kernel.org/linux-erofs/20260804033214.211267-2-martin@amutable.com/
[2] https://lore.kernel.org/linux-erofs/20260804033214.211267-3-martin@amutable.com/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?h=experimental-tests&id=4b02ea1792c14cb9f250bd55aced5614e699397a
[4] https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?h=experimental-tests&id=887ce207bc8b068de9771b736333a8da6d939670


  reply	other threads:[~2026-08-26 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  3:32 [PATCH 0/3] erofs-utils: tests: cover the canonical xattr order Martin Pitt
2026-08-04  3:32 ` [PATCH 1/3] erofs-utils: tests: fix broken loop in POSIX shells Martin Pitt
2026-08-04  3:32 ` [PATCH 2/3] erofs-utils: tests: look up programs with command -v Martin Pitt
2026-08-04  3:32 ` [PATCH 3/3] erofs-utils: tests: check that the xattr layout is order-independent Martin Pitt
2026-08-26 19:18   ` Martin Pitt [this message]
2026-08-27 12:10     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao88F-F9wTDhKjvI@piware.de \
    --to=martin@amutable.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox