Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: ChengyuZhu6 <hudson@cyzhu.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org,
	Chengyu Zhu <hudsonzhu@tencent.com>
Subject: Re: [PATCH v2] erofs: delimit inode_share cache key components
Date: Mon, 7 Sep 2026 17:10:04 +0800	[thread overview]
Message-ID: <ap5_bAWLkTTqbHen@XiangdeMacBook-Pro.local> (raw)
In-Reply-To: <20260907083319.69644-1-hudson@cyzhu.com>

On Mon, Sep 07, 2026 at 04:33:19PM +0800, ChengyuZhu6 wrote:
> From: Chengyu Zhu <hudsonzhu@tencent.com>
> 
> Previously, inode_share keys were encoded as follows:
> 
>   fingerprint || domain_id
> 
> It would be better to have a separator between the fingerprint and domain
> ID so that the fingerprint won't be parsed as part of a domain ID.
> 
> Change the key encoding as follows:
> 
>   domain_id || '\0' || fingerprint
> 
> Since domain_id is a NUL-terminated string, this makes the in-memory key
> indices unambiguous.
> 
> Signed-off-by: Chengyu Zhu <hudsonzhu@tencent.com>

Reviewed-by: Gao Xiang <xiang@kernel.org>

Thanks,
Gao Xiang


      reply	other threads:[~2026-09-07  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  7:24 [PATCH] erofs: delimit inode_share cache key components ChengyuZhu6
2026-09-07  8:18 ` Gao Xiang
2026-09-07  8:33 ` [PATCH v2] " ChengyuZhu6
2026-09-07  9:10   ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap5_bAWLkTTqbHen@XiangdeMacBook-Pro.local \
    --to=xiang@kernel.org \
    --cc=hudson@cyzhu.com \
    --cc=hudsonzhu@tencent.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox