Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>
Cc: xiang@kernel.org, linux-erofs@lists.ozlabs.org,
	stopire@gmail.com, zhanxusheng@xiaomi.com
Subject: Re: [PATCH 5/5] erofs-utils: mkfs: enable `--blobdev` for flat inode layouts
Date: Wed, 2 Sep 2026 23:58:12 +0800	[thread overview]
Message-ID: <aphHlNHyv85i1A3u@XiangdeMacBook-Pro.local> (raw)
In-Reply-To: <20260902081141.3309090-1-zhanxusheng@xiaomi.com>

Hi Xusheng,

On Wed, Sep 02, 2026 at 04:11:41PM +0800, Zhan Xusheng wrote:
> Hi Xiang,
> 
> --blobdev without --chunksize works here, and fsck.erofs --extract returns
> the tree byte for byte.
> 
> Two things in erofs_allocate_inode_bh_data().
> 
> The bmgr initializer is dead, since the chain below covers all three signs
> of device_id, and for device_id > 0 it picks the metazone.
> 
> The new message prints the sentinel when the metazone is the unavailable
> one.  mkfs.erofs --incremental --MZ over an image built with --MZ:
> 
>   e1959e9  cannot allocate data in the metazone when unavailable for ...
>   0badea0  cannot allocate data in unavailable device -1 for ...
> 
> Both refuse it, so nothing changed there, but "device -1" no longer tells
> the user which target was meant.

Those comments above are hard to follow for me.

Could you just submit patches instead to demo your intention?

I could apply directly if your suggestion makes more sense.

Thanks,
Gao Xiang

> 
> Thanks,
> Zhan Xusheng
> 


      reply	other threads:[~2026-09-02 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  2:50 [PATCH 1/5] erofs-utils: add missing device_id derivation for flattened devices Gao Xiang
2026-09-02  2:50 ` [PATCH 2/5] erofs-utils: lib: unexport "erofs/chunk.h" Gao Xiang
2026-09-02  2:50 ` [PATCH 3/5] erofs-utils: lib: migrate `c_chunkbits` and `c_blobdev_path` Gao Xiang
2026-09-02  7:14   ` Zhan Xusheng
2026-09-02  2:50 ` [PATCH 4/5] erofs-utils: mkfs: introduce ddev_id_def Gao Xiang
2026-09-02  2:50 ` [PATCH 5/5] erofs-utils: mkfs: enable `--blobdev` for flat inode layouts Gao Xiang
2026-09-02  8:11   ` Zhan Xusheng
2026-09-02 15:58     ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aphHlNHyv85i1A3u@XiangdeMacBook-Pro.local \
    --to=xiang@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=stopire@gmail.com \
    --cc=zhanxusheng1024@gmail.com \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox