From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25EE360A260E for ; Fri, 13 Nov 2026 09:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=p8cYu1HM Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jQt0T04n0z3bZm; Fri, 13 Nov 2026 20:55:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::635" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794563704; cv=none; b=ZwU44HMNuXREYspa/4KH70wY6g0edr6zholKXNR6+3pDqLO1sldXAPHQxhAJlgqRJ9LFRM/6MVK3uNVO3g9lg5qXspdCfxrtAorY74LGcyx/wkevF1pPYQatq9mBLC3nYvBOSZ0hEE+d/wKOUNfKLIea2WZAq1s0XVaCug5iMX1zUtyFc3vE8PY+8sKyd/VdR5TVtMLAXTKoUAn3cb+jC1I/ucLqiJ7wWfzD172YL34Ftg6P1EMIhs5P3G2456ogEOL/N+4H1RwBXBb6N3OZWdzNh30pAvZMt33hKg7Pwy6TZaEF0XH7Yd8j7+gBunVxvBdK2IkfFJlgNYL3R471FA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794563704; c=relaxed/relaxed; bh=G8DmFU4pJwAPCJlqHBF8SKasEEThxtJNlC1sg/CSkLw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=edI8gMkGjPVDrfbftzim7j6PFfxuRVFXtKy4SKJllkYxXTEhvsjiCns+UYTGi4HBHl/dc5P1ciW34uweGcizv88UNBdMGT2AjPyXtB8XgyjsveNkr1taE1uu7fnsVMXvMjiCJpPaAjyarfZ7L0ZD3/matMrgx/G2OA1SDy3+u+FkEA1ofuFA7cAvhHXfsFjd/I9PFrNuMrZ9Q2fsqCEmwZMNMDlQ1g2s9X2mtOg7br9SJNiH2/qP++lOvYUs6yxfl4skausA5lQ4o1YVgABjr7GS2NocVt6bRWHldh7fE3g5X5RK0jMo7zHJnXOiwjaKLg98znUOXKivENWZLIoUaQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=amutable.com; dkim=pass (2048-bit key; unprotected) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=p8cYu1HM; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::635; helo=mail-ej1-x635.google.com; envelope-from=alex@amutable.com; receiver=lists.ozlabs.org) smtp.mailfrom=amutable.com Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=p8cYu1HM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=amutable.com (client-ip=2a00:1450:4864:20::635; helo=mail-ej1-x635.google.com; envelope-from=alex@amutable.com; receiver=lists.ozlabs.org) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jQt0Q63p2z3bX3 for ; Fri, 13 Nov 2026 20:55:02 +1100 (AEDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-c4395d31228so145414366b.1 for ; Fri, 13 Nov 2026 01:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794563698; x=1795168498; darn=lists.ozlabs.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=G8DmFU4pJwAPCJlqHBF8SKasEEThxtJNlC1sg/CSkLw=; b=p8cYu1HMRE+1uxIb918MvbGeMcfPcxop1zS6jRqo486O366tyQibpf2w12r0TQe+Vk r520b5DFHfwRKenZMFmsO4x2Mv7UztbBvP+YIunETdbkhUeCiP6OF41LBYv+61IRle22 5Pl+U+CSx/6JyT45+B0WfYzIkQR8+hLSVHYpsYhSS8VahwX//KVuj2zoFp41qOjwKb2h YhnxsLaM4KVn5ojEyLIk9hKVhYWlB/exWVjyDclbKUuUUJTiiAYyildeCJQ9ajHqVkJE m4ppzRdJTS25Z+2iUvxhVzXW344oW9AeHhJGU2bG/8JxdrEUXGKCKjuZ8ZAGGPM9igSG ZhPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794563698; x=1795168498; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G8DmFU4pJwAPCJlqHBF8SKasEEThxtJNlC1sg/CSkLw=; b=jSVRVEzEUUKxuq76KGTdC6f4eEv78J8dXoWVkfuvfaT+Yed+8TwzeTlNHRhzMnL+Rq gIqOk3d/7g5VJOw7G9h3K08gsDsjrVbP+VyqOsNSiuGQYnnJAQhvbXIx/rM7SENtdXI0 gpS9IjYoCl1yJmlY0WwofIqbpYQwW55l4jFJYwUkhO2Q9Y4DRCFTBmZfn6KR11s1lhov hLbZeSSPRgCUw55Wg+21eapvmkXewXmediF7Bx00BfksmSGehCG5XyqPqmlOUYn4KpiS LMtP7IkDRmNziGG0CgY2egOfrXzmt9ucuhXE14xJdYsRE3MVcpjMDyEU/1R/7luMtEJn Jiug== X-Forwarded-Encrypted: i=1; AL+hErHdYhvYDrd1rwPdeo3U9K1giAgdghBdmeyL6DmxlBVHGBSylptr11sG9B3cKdMC3u0bjOLbDRBOBpTI3w==@lists.ozlabs.org X-Gm-Message-State: APuU4Z96bwajN2G38yiNcJFEf02Qt581lZZNwhNO5xy2GmSV5Axi952S MzA9d4ivlaEbG+dZYqG3UaXqhHn/Pnop9OmgJZ6oeaXj25x7AWo6gFIlzxuNXi9+ezcb X-Gm-Gg: AYBFou1jatx3Jjs7YSwTLPUDsFDsmVK2d8o2H+z4swl7IZ5uaLfMmeNLgV0zkg8fqca 3rWAgLjeT8d9LqklQIf59q2X6svpNVaTgVGAx8Eb5MSKW52YBALiI3lDTm5XcbIfjpxsivxgZy7 PNo2AiCFgUNGja7KOdQ7dMY66DynXxaQML9spGTRFBK8S+2feVOMtcdEl68Byf/SuhlE/m4mMRB FMv5RU3zDiGn6+1elwg8AR9YHbFiSt+9lm17pXXvaYphPZWRr6p/DYwvf642KXfjWehvSU8eUfW Gxajf4xXsYcBAHRLoqP/hed5TmTy6IeJAUa1hE72Exuhxub7mYyxhAqMzp0Fqt3loafYdaWAjwj RBepGPjdxQpA4Wt1kdIKMfz0ynyc5jqGnU2veJZgvL37lhHJVJDIw0RXMhCcaGZoxlfa4xQvqyu NH3N7THAbEa2jHp9GYXaYMtjhDy1QxoOarpWDJm462aTVmHtYrO2vDY73Tc9KcENAbmAocpz9Eo HqrACGnM26GyF7DwsagDkcV+Y4vsmBKja0ngkTRB3bwKgjOFtjfyAf14gRVnZKwmQD4Mk0u3azw ODvaWkeTllLrbKvyOJrzTn7dpqytaVb97d/tZ/pyCEgChr7Wg3syO3TshyYYxJU= X-Received: by 2002:a17:907:ea93:b0:c41:4c20:5a80 with SMTP id a640c23a62f3a-c50963bdb9bmr198299566b.44.1794563698514; Fri, 13 Nov 2026 01:54:58 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c50957c6c1fsm75151566b.0.2026.11.13.01.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 01:54:58 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 01/41] loop: refuse backing files that aren't open for reading From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org Date: Fri, 13 Nov 2026 10:54:56 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-1-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-1-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > loop_configure() takes any file as long as it implements - > >read_iter(). > Loop itself never checked whether the file was actually opened for > reading. Buffered I/O went through vfs_iter_read() which refuses > files > without FMODE_READ. Direct I/O has called ->read_iter() of the > backing > file directly ever since loop grew support for it. >=20 > Since commit f2fed441c69b ("loop: stop using vfs_iter_{read,write} > for > buffered I/O") buffered I/O calls ->read_iter() directly as well. > That > commit was about O_DIRECT handling and the FMODE_READ check went away > as a side effect. >=20 > So whoever can set up a loop device can read a file it was only > allowed > to open for writing. Open the file O_WRONLY, configure a loop device > with it and read the contents through the loop device. >=20 > Refuse backing files that aren't open for reading. Loop always reads > from its backing file so a write-only backing file never made sense > in > the first place. >=20 > Fixes: bc07c10a3603 ("block: loop: support DIO & AIO") > Fixes: f2fed441c69b ("loop: stop using vfs_iter_{read,write} for > buffered I/O") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn > --- > =C2=A0drivers/block/loop.c | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index a3325ceab484..c96e35c3ef42 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -528,6 +528,9 @@ static void loop_assign_backing_file(struct > loop_device *lo, struct file *file) > =C2=A0 > =C2=A0static int loop_check_backing_file(struct file *file) > =C2=A0{ > + if (!(file->f_mode & FMODE_READ)) > + return -EBADF; > + > =C2=A0 if (!file->f_op->read_iter) > =C2=A0 return -EINVAL; > =C2=A0