From: Chao Yu <chao@kernel.org>
To: Xin Yin <yinxin.x@bytedance.com>,
hsiangkao@linux.alibaba.com, jefflexu@linux.alibaba.com
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs: fix crash when enable tracepoint cachefiles_prep_read
Date: Sun, 29 May 2022 14:08:54 +0800 [thread overview]
Message-ID: <bc642f61-c353-5d33-28a6-b5c0ad21335d@kernel.org> (raw)
In-Reply-To: <20220527101800.22360-1-yinxin.x@bytedance.com>
On 2022/5/27 18:18, Xin Yin wrote:
> RIP: 0010:trace_event_raw_event_cachefiles_prep_read+0x88/0xe0
> [cachefiles]
> Call Trace:
> <TASK>
> cachefiles_prepare_read+0x1d7/0x3a0 [cachefiles]
> erofs_fscache_read_folios+0x188/0x220 [erofs]
> erofs_fscache_meta_readpage+0x106/0x160 [erofs]
> do_read_cache_folio+0x42a/0x590
> ? bdi_register_va.part.14+0x1a7/0x210
> ? super_setup_bdi_name+0x76/0xe0
> erofs_bread+0x5b/0x170 [erofs]
> erofs_fc_fill_super+0x12b/0xc50 [erofs]
>
> This tracepoint uses rreq->inode, should set it when allocating.
>
> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache
> readpage/readahead")
Should not wrap long 'fixes' line.
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2022-05-29 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 10:18 [PATCH] erofs: fix crash when enable tracepoint cachefiles_prep_read Xin Yin
2022-05-27 12:01 ` JeffleXu
2022-05-28 13:54 ` Gao Xiang
2022-05-29 6:08 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc642f61-c353-5d33-28a6-b5c0ad21335d@kernel.org \
--to=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox