From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Utkal Singh <singhutkal015@gmail.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: lib: return error on ZSTD decompression length mismatch
Date: Thu, 19 Mar 2026 18:18:53 +0800 [thread overview]
Message-ID: <c5229fc2-1897-49ae-8d05-acf28670cac8@linux.alibaba.com> (raw)
In-Reply-To: <20260319101721.17105-1-singhutkal015@gmail.com>
On 2026/3/19 18:17, Utkal Singh wrote:
> When ZSTD_decompress() returns a size different from the expected
> decoded size, the current code logs an error and jumps to cleanup
> without setting ret to a negative value.
>
> Since ret still holds a positive byte count, the caller interprets
> it as success, potentially treating incorrectly decompressed data
> as valid output.
>
> Set ret to -EIO before jumping to cleanup, consistent with the
> existing ZSTD_isError() handling above.
>
> Signed-off-by: Utkal Singh <singhutkal015@gmail.com>
Please stop resending the patch without any modification.
next prev parent reply other threads:[~2026-03-19 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 10:17 [PATCH] erofs-utils: lib: return error on ZSTD decompression length mismatch Utkal Singh
2026-03-19 10:18 ` Gao Xiang [this message]
2026-03-20 8:26 ` Nithurshen
2026-03-20 9:29 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5229fc2-1897-49ae-8d05-acf28670cac8@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=singhutkal015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox