From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5304A108E1C7 for ; Thu, 19 Mar 2026 10:19:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fc1rR73vXz2ykV; Thu, 19 Mar 2026 21:19:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=115.124.30.97 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773915543; cv=none; b=DPGp3Ce6dpKvAcK6uPzSmswc5UYBWQfNuiI1zl5EQAjki4QSZJ3y0aCxm0QH9R66EBA6WpincyY4eiseBr9odFIBc0VWDYkwzTJPQNwMyI8xv3SZCC6zD+D1bQ4ZFVrFKZTvlX9UAPoCy7mRcy+3WUkHfT9O8ufN9/Z588pKK/eyzH6+K4nVytES+O1hpADvJL58dB8vExzPpI9V5dTsMQeWf4moda/kCcwo++ZrJibaUUcVB3cRFL/OeURSPxTQvOzXRWkZdAbfgYzE/AsiqWKQhPQRuYpIlbpiQWf4vBiM8IJHtA35reKwSBGPFAtdirBhxJRaYzBR/tvQGwOVXQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773915543; c=relaxed/relaxed; bh=BlW8MzDdqjOuXUNvwFbPWBwQIcaiEctArAJ/zeIEZTg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hxlrvXMtGBae9NOKiuIe8QenzB6lTUiU3dtpKPn8ktSFcWNuLHDWu7LwlkG26ssIg8wUnkNyan8ITroyo7QOu1QZIhwXY0pEOZb6f0TDoP8+29iPPeIySyK8lCMku3d9ZzNBgvdqs8GoQIbedCBnizmeVoIUlWWo0Yx+mLbQ0Wb2pQtWXsSYB4pugpt4N39+pwgeuSFP5sMmp+OLUUQZe144jf9ajdQuiw1M2jtMH6/m4gePhpY9jF9laci9H+MI0kaibGNMywY+tRPlaS6vzdMluu3xTDURHr5gYQtnGecO6uZ1V4SSdAm4LmxQ0RNfKqmTMqZm3GJcuEkhqIO2xA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=sDqXiUg2; dkim-atps=neutral; spf=pass (client-ip=115.124.30.97; helo=out30-97.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=sDqXiUg2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.97; helo=out30-97.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fc1rP56MMz2ygT for ; Thu, 19 Mar 2026 21:19:00 +1100 (AEDT) DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1773915535; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=BlW8MzDdqjOuXUNvwFbPWBwQIcaiEctArAJ/zeIEZTg=; b=sDqXiUg2zsem6G6EZs1vzVQN5qa4zb1dlU0jln+Vur1XLc5/b5qorvGl8HSP65Fg2GuAa6N0dmC/7dQ718jPmMkGin+X2yTMOR4f8iQqxUjmoqIsJv4unwe+DjuOLiwGOO7wm3gssit2nxYFIMv3uvYsugcofq8NAXKmvCJ5lsc= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R551e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037026112;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_---0X.I5jMp_1773915533; Received: from 30.170.14.2(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0X.I5jMp_1773915533 cluster:ay36) by smtp.aliyun-inc.com; Thu, 19 Mar 2026 18:18:54 +0800 Message-ID: Date: Thu, 19 Mar 2026 18:18:53 +0800 X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] erofs-utils: lib: return error on ZSTD decompression length mismatch To: Utkal Singh , linux-erofs@lists.ozlabs.org References: <20260319101721.17105-1-singhutkal015@gmail.com> From: Gao Xiang In-Reply-To: <20260319101721.17105-1-singhutkal015@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/3/19 18:17, Utkal Singh wrote: > When ZSTD_decompress() returns a size different from the expected > decoded size, the current code logs an error and jumps to cleanup > without setting ret to a negative value. > > Since ret still holds a positive byte count, the caller interprets > it as success, potentially treating incorrectly decompressed data > as valid output. > > Set ret to -EIO before jumping to cleanup, consistent with the > existing ZSTD_isError() handling above. > > Signed-off-by: Utkal Singh Please stop resending the patch without any modification.