Re: [PATCH v1] erofs: remove the guard of showing domain_id and fsid

[Gao Xiang <hsiangkao@linux.alibaba.com>]

On 2026/3/30 16:48, Yuezhang.Mo@sony.com wrote:
>> On 2026/3/30 15:32, Yuezhang Mo wrote:
>>> This change fixes an issue where domain_id was not shown when
>>> CONFIG_EROFS_FS_PAGE_CACHE_SHARE is enabled, as this configuration
>>> is mutually exclusive with CONFIG_EROFS_FS_ONDEMAND.
>>>
>>> Both domain_id and fsid fields are present in struct erofs_sb_info
>>> regardless of configuration. They are not set if the configurations
>>> are not enabled, and remain NULL. Therefore, the conditional guard
>>> in erofs_show_options() are unnecessary and can be removed.
>>>
>>> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
>>> Reviewed-by: Friendy Su <friendy.su@sony.com>
>>> Reviewed-by: Daniel Palmer <daniel.palmer@sony.com>
>>
>> `domain_id` is a user-sensitive information for the page cache
>> sharing feature (much like passwd), so it shouldn't be shown
>> in the mount option by design, and only the mounter should
>> know what it was set.
> 
> Oh, this is part of the design, not a bug. Thank you for your explanation.

Yes, if you need that information in the follow-up steps,
you should keep somewhere in the userspace: but the proper
permission is needed (e.g. like /etc/shadow).

Thanks,
Gao Xiang