From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15F79C64ED6 for ; Tue, 28 Feb 2023 05:59:09 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PQms73rPxz3cBq for ; Tue, 28 Feb 2023 16:59:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.98; helo=out30-98.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=) Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PQms246Rcz2ynf for ; Tue, 28 Feb 2023 16:59:01 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R411e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VchnyNb_1677563936; Received: from 30.97.48.254(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VchnyNb_1677563936) by smtp.aliyun-inc.com; Tue, 28 Feb 2023 13:58:57 +0800 Message-ID: Date: Tue, 28 Feb 2023 13:58:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5] erofs: add per-cpu threads for decompression as an option To: Sandeep Dhavale References: <20230208093322.75816-1-hsiangkao@linux.alibaba.com> <8e067230-ce1b-1c75-0c23-87b926357f96@linux.alibaba.com> <1f926a20-6b45-137d-4e78-30025ba33574@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Yue Hu , linux-erofs@lists.ozlabs.org, LKML , Nathan Huckleberry Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/2/28 13:51, Sandeep Dhavale wrote: > On Mon, Feb 27, 2023 at 9:01 PM Gao Xiang wrote: >> >> Hi Sandeep, >> >> On 2023/2/28 12:47, Sandeep Dhavale via Linux-erofs wrote: >>> Hi all, >>> I completed the tests and the results are consistent with >>> our previous observation. We can see that removing WQ_UNBOUND >>> helps but the scheduling latency by using high priority per cpu >>> kthreads is even lower. Below is the table. >>> >>> |---------------------+-------+-------+------+-------| >>> | Table | avg | med | min | max | >>> |---------------------+-------+-------+------+-------| >>> | Default erofs | 19323 | 19758 | 3986 | 35051 | >>> |---------------------+-------+-------+------+-------| >>> | !WQ_UNBOUND | 11202 | 10798 | 3493 | 19822 | >>> |---------------------+-------+-------+------+-------| >>> | hipri pcpu kthreads | 7182 | 7017 | 2463 | 12300 | >>> |---------------------+-------+-------+------+-------| >> >> May I ask did it test with different setup since the test results >> in the original commit message are: >> > Hi Gao, > Yes I did the test on the different (older) hardware than my original testing > (but the same one Nathan had used) to remove that as a variable. Ok, good to know that. > > Thanks, > Sandeep. > >> +-------------------------+-----------+----------------+---------+ >> | | workqueue | kthread_worker | diff | >> +-------------------------+-----------+----------------+---------+ >> | Average (us) | 15253 | 2914 | -80.89% | >> | Median (us) | 14001 | 2912 | -79.20% | >> | Minimum (us) | 3117 | 1027 | -67.05% | >> | Maximum (us) | 30170 | 3805 | -87.39% | >> | Standard deviation (us) | 7166 | 359 | | >> +-------------------------+-----------+----------------+---------+ >> >> Otherwise it looks good to me for now, hopefully helpful to Android >> users. >> >> Thanks, >> Gao Xiang >> >>> >>> >>> Thanks, >>> Sandeep.