From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 080DFC636CC for ; Thu, 16 Feb 2023 12:14:46 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PHYm51lzwz3f2l for ; Thu, 16 Feb 2023 23:14:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.133; helo=out30-133.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=) Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PHYly3w0Dz2yHT for ; Thu, 16 Feb 2023 23:14:37 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VbogEOy_1676549672; Received: from 30.221.132.175(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VbogEOy_1676549672) by smtp.aliyun-inc.com; Thu, 16 Feb 2023 20:14:33 +0800 Message-ID: Date: Thu, 16 Feb 2023 20:14:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] erofs: fix an error code in z_erofs_init_zip_subsystem() To: Dan Carpenter , Sandeep Dhavale References: From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-erofs@lists.ozlabs.org, Yue Hu , kernel-janitors@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/2/16 20:13, Dan Carpenter wrote: > Return -ENOMEM if alloc_workqueue() fails. Don't return success. > > Fixes: d8a650adf429 ("erofs: add per-cpu threads for decompression as an option") > Signed-off-by: Dan Carpenter Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > fs/erofs/zdata.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c > index 8ea3f5fe985e..3247d2422bea 100644 > --- a/fs/erofs/zdata.c > +++ b/fs/erofs/zdata.c > @@ -475,8 +475,10 @@ int __init z_erofs_init_zip_subsystem(void) > > z_erofs_workqueue = alloc_workqueue("erofs_worker", > WQ_UNBOUND | WQ_HIGHPRI, num_possible_cpus()); > - if (!z_erofs_workqueue) > + if (!z_erofs_workqueue) { > + err = -ENOMEM; > goto out_error_workqueue_init; > + } > > err = erofs_init_percpu_workers(); > if (err)