From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: generate preallocated extents for tarerofs
Date: Tue, 1 Aug 2023 10:52:04 +0800 [thread overview]
Message-ID: <cd2963e7-9813-c378-e9db-632089f50bf0@linux.alibaba.com> (raw)
In-Reply-To: <20230729133201.16894-1-hsiangkao@linux.alibaba.com>
On 7/29/23 9:32 PM, Gao Xiang wrote:
>
> -int erofs_blob_remap(struct erofs_sb_info *sbi)
> +int tarerofs_write_chunk_data(struct erofs_inode *inode, erofs_off_t data_offset)
> +{
> + struct erofs_sb_info *sbi = inode->sbi;
> + unsigned int chunkbits = ilog2(inode->i_size - 1) + 1;
What if inode->i_size is 0 ?
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-08-01 2:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 13:32 [PATCH] erofs-utils: generate preallocated extents for tarerofs Gao Xiang
2023-07-31 4:51 ` Jingbo Xu
2023-08-01 3:05 ` Gao Xiang
2023-08-01 2:52 ` Jingbo Xu [this message]
2023-08-01 3:04 ` Gao Xiang
2023-08-01 3:31 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2963e7-9813-c378-e9db-632089f50bf0@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox