From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C58BEC433F5 for ; Fri, 18 Mar 2022 05:27:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KKXZL2Q4gz30KR for ; Fri, 18 Mar 2022 16:27:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.57; helo=out30-57.freemail.mail.aliyun.com; envelope-from=jefflexu@linux.alibaba.com; receiver=) Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KKXZG4tQ7z2yPv for ; Fri, 18 Mar 2022 16:27:00 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R151e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=jefflexu@linux.alibaba.com; NM=1; PH=DS; RN=16; SR=0; TI=SMTPD_---0V7UqACk_1647581210; Received: from 30.225.24.52(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V7UqACk_1647581210) by smtp.aliyun-inc.com(127.0.0.1); Fri, 18 Mar 2022 13:26:51 +0800 Message-ID: Date: Fri, 18 Mar 2022 13:26:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [Linux-cachefs] [PATCH v5 10/22] erofs: add mode checking helper Content-Language: en-US To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, gregkh@linuxfoundation.org, tao.peng@linux.alibaba.com, willy@infradead.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, linux-fsdevel@vger.kernel.org, luodaowen.backend@bytedance.com, eguan@linux.alibaba.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org References: <20220316131723.111553-1-jefflexu@linux.alibaba.com> <20220316131723.111553-11-jefflexu@linux.alibaba.com> From: JeffleXu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 3/17/22 1:36 PM, Gao Xiang wrote: > On Wed, Mar 16, 2022 at 09:17:11PM +0800, Jeffle Xu wrote: >> Until then erofs is exactly blockdev based filesystem. In other using >> scenarios (e.g. container image), erofs needs to run upon files. >> >> This patch set is going to introduces a new nodev mode, in which erofs >> could be mounted from a bootstrap blob file containing complete erofs >> image. >> >> Add a helper checking which mode erofs works in. >> >> Signed-off-by: Jeffle Xu >> --- >> fs/erofs/internal.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h >> index e424293f47a2..f66af9ebda43 100644 >> --- a/fs/erofs/internal.h >> +++ b/fs/erofs/internal.h >> @@ -161,6 +161,11 @@ struct erofs_sb_info { >> #define set_opt(opt, option) ((opt)->mount_opt |= EROFS_MOUNT_##option) >> #define test_opt(opt, option) ((opt)->mount_opt & EROFS_MOUNT_##option) >> >> +static inline bool erofs_bdev_mode(struct super_block *sb) > > How about renaming it as erofs_is_nodev_mode()? Sure, will be renamed in the next version. -- Thanks, Jeffle