From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 2/4] erofs-utils: add a built-in DEFLATE compressor
Date: Mon, 10 Jul 2023 12:55:04 +0800 [thread overview]
Message-ID: <ead1cb72-392d-f00f-da32-4afa671ec9bf@linux.alibaba.com> (raw)
In-Reply-To: <607b9642-7bdc-e4f6-f8cc-0096e3c99341@linux.alibaba.com>
(forgot to respond something...)
On 2023/7/10 12:51, Gao Xiang wrote:
>
>
...
>>
>>>
>>> I think we could use this way first for the new Zstd support (if they don't have
>>> bandwidth to add a offical fixed-sized output approach), but considering deflate
>>> algorithm is quite easy for me to understand so at least I could have a simple
>>> built-in one to avoid external dependency (mainly considering zlib since it's
>>> quite outdated). Since EROFS is actually offline compression so the compressed
>>> data correctness can always be checked in advance before image release.
>>
>> Writing an optimized compressor, especially one that implements high compression
>> levels, is very hard. Are you sure it's something you want to implement and
>> maintain in erofs-utils?
Nope, as I said earlier, I'd like to write a simple one to replace zlib
functionality (kite_deflate already does), and I hope more popular encoders
could have offical modes for EROFS in the long term. That is something that
I wish to the opensource communities...
Thanks,
Gao Xiang
next prev parent reply other threads:[~2023-07-10 4:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 18:25 [PATCH 0/4] erofs-utils: add DEFLATE compression support Gao Xiang
2023-07-09 18:25 ` [PATCH 1/4] erofs-utils: switch to effective unaligned access Gao Xiang
2023-07-09 18:25 ` [PATCH 2/4] erofs-utils: add a built-in DEFLATE compressor Gao Xiang
2023-07-10 2:33 ` Eric Biggers
2023-07-10 3:01 ` Gao Xiang
2023-07-10 4:16 ` Eric Biggers
2023-07-10 4:51 ` Gao Xiang
2023-07-10 4:55 ` Gao Xiang [this message]
2023-07-09 18:25 ` [PATCH 3/4] erofs-utils: fuse: add DEFLATE algorithm support Gao Xiang
2023-07-09 18:25 ` [PATCH 4/4] erofs-utils: mkfs: " Gao Xiang
2023-07-09 18:45 ` [PATCH v2 3/4] erofs-utils: fuse: " Gao Xiang
2023-07-09 18:45 ` [PATCH v2 4/4] erofs-utils: mkfs: " Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead1cb72-392d-f00f-da32-4afa671ec9bf@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=ebiggers@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox