Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
	Yue Hu <zbestahu@gmail.com>,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	Sandeep Dhavale <dhavale@google.com>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: complete fscache pseudo-bio once when a read is split
Date: Sat, 20 Jun 2026 00:32:01 +0800	[thread overview]
Message-ID: <ee412c09-dd3f-4918-88de-3bedf6f25122@linux.alibaba.com> (raw)
In-Reply-To: <CAJJ9bXws=fnBgMMbGcuWdhSRRe2yNb-QjFP-CKW=vaA0dWd+-g@mail.gmail.com>



On 2026/6/20 00:21, Michael Bommarito wrote:
> On Fri, Jun 19, 2026 at 10:20 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>> fscache is already deprecated, I will remove this path
>> in this or the next cycle: it's not worth to improve
>> this, and bio_inc_remaining is suspicious since I never
>> tend to introduce chain pseudo-bios.
> 
> I didn't chase a POC for this one, but I can't rule out an LPE on the
> or at least helpful shaping from this.
> 
> I know it's not relevant going forward, but the UAF / double free will
> live forever unless stable@ gets something.

It's already _deprecate_ for almost two years: and
I believe there should be more serious issues all
over the kernel, why just focus on a deprecated
feature?

Or please provide an accurate reproducible way first
so that I can play with that myself, I think I can
fix it in a cleaner way. If it's really necessary,
it will be fixed to the stable kernels only later,
but this feature will be removed in the near future
upstream instead.

Thanks,
Gao Xiang

> 
> Thanks,
> Mike



      reply	other threads:[~2026-06-19 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 13:58 [PATCH] erofs: complete fscache pseudo-bio once when a read is split Michael Bommarito
2026-06-19 14:20 ` Gao Xiang
2026-06-19 16:21   ` Michael Bommarito
2026-06-19 16:32     ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee412c09-dd3f-4918-88de-3bedf6f25122@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=dhavale@google.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.bommarito@gmail.com \
    --cc=xiang@kernel.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox