* [PATCH] ext4: remove unneeded code in ext4_unlink
@ 2014-11-24 6:43 Namjae Jeon
2014-11-25 21:47 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2014-11-24 6:43 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4
Setting retval to zero is not needed in ext4_unlink.
Remove unneeded code.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
fs/ext4/namei.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 4262118..2291923 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2814,7 +2814,6 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry)
ext4_orphan_add(handle, inode);
inode->i_ctime = ext4_current_time(inode);
ext4_mark_inode_dirty(handle, inode);
- retval = 0;
end_unlink:
brelse(bh);
--
1.7.11-rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: remove unneeded code in ext4_unlink
2014-11-24 6:43 [PATCH] ext4: remove unneeded code in ext4_unlink Namjae Jeon
@ 2014-11-25 21:47 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2014-11-25 21:47 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-ext4
On Mon, Nov 24, 2014 at 03:43:47PM +0900, Namjae Jeon wrote:
> Setting retval to zero is not needed in ext4_unlink.
> Remove unneeded code.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-25 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 6:43 [PATCH] ext4: remove unneeded code in ext4_unlink Namjae Jeon
2014-11-25 21:47 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).