From: Namjae Jeon <namjae.jeon@samsung.com>
To: "'Lukáš Czerner'" <lczerner@redhat.com>
Cc: 'Theodore Ts'o' <tytso@mit.edu>,
'linux-ext4' <linux-ext4@vger.kernel.org>
Subject: RE: [PATCH 3/3] ext4: disable COLLAPSE_RANGE for bigalloc
Date: Thu, 17 Apr 2014 20:27:00 +0900 [thread overview]
Message-ID: <008c01cf5a2f$f35f5e30$da1e1a90$@samsung.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1404171313210.2143@localhost.localdomain>
> > }
> >
> > + if (EXT4_SB(inode->i_sb)->s_cluster_ratio > 1) {
> > + ret = -EOPNOTSUPP;
> > + goto out_mutex;
> > + }
> > +
>
> I do not think we need to hold mutex for this. You can move it to
> the beginning of the function preferably right after S_ISREG check.
>
> Otherwise it looks ok, but it would be better if we could fix it :)
Okay, Thanks for review!
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> > truncate_pagecache_range(inode, ioffset, -1);
> >
> > /* Wait for existing dio to complete */
> >
prev parent reply other threads:[~2014-04-17 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 22:30 [PATCH 3/3] ext4: disable COLLAPSE_RANGE for bigalloc Namjae Jeon
2014-04-17 11:15 ` Lukáš Czerner
2014-04-17 11:27 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008c01cf5a2f$f35f5e30$da1e1a90$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).