From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D3FCA9EC8 for ; Thu, 17 Oct 2019 23:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A3D121D7A for ; Thu, 17 Oct 2019 23:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571356755; bh=UXgGNvzXXZ0A32AwFkiFv+Dt3+U9G8Fb4OuimeSawk4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=S5QWNcFBqSmV//3hX5gMai1pKD2qqRer6jX+KRQtbIG6oCXI8Y6G1K4Hg5iof6AKw jaXe8kKeIxdFyIc5tRZ40jGW6K+ApXutPkCqsgOfglVgGT21onODqCFRJZP+ox5c5J 599gCXXyomOBa1/bpmdrnzRXstUSMmHn8CY6fmXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441848AbfJQX7P (ORCPT ); Thu, 17 Oct 2019 19:59:15 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:40583 "EHLO mail-io1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729190AbfJQX7P (ORCPT ); Thu, 17 Oct 2019 19:59:15 -0400 Received: by mail-io1-f44.google.com with SMTP id h144so5267022iof.7 for ; Thu, 17 Oct 2019 16:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n68VTQNC8v2GWdF9aNbeWEV+391ytDDLOJo8jsaK55U=; b=FDy6dalQYyXQ2LxUmG9wbtw5osTMTbxQVG4j6cbs0NcYZD4ytzNVA6UvceEd/KKEuR UiJPPsLJUyC0jRZSsqH3Mj2iulBbUHUEQ5wIurjcXNSrVFdKQs9rfcd4Zo5gESnHRkMf 33AZKeTMhtJ96tWSqM8K1qfbNFgddCElbU8As= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n68VTQNC8v2GWdF9aNbeWEV+391ytDDLOJo8jsaK55U=; b=RX6tcYdsQ3C6OZt79Wzw14/5Y03QPa9SG5bClZewaEhdWbJuH3R89weTX08YRNt9Q/ KZLI11Ofhe5pIpGEBp/tZrZmfij3ahRzC0c3DeleqBVyxREFJm42er6x2lgW0dtZpOd3 tENIjyq+o+5MWnK8gmBcnn4nKiObVSxxJykBRpVyi1UUbCL1UpE5ml6qGpqCVZlIvQiL EUhbWSNrbBpIM/p7QRs10ZIMBVvmHGMdgkcOhC/7SUCjNpv6umzJvF6zRkyDZ6zzRQxQ HJEUQ8NAzOdD96HeyuOTEjxQYj+LzDZ8pkiHjyeL7pnRqbDgVanAOLX2dqvGHiZQpHH6 54yA== X-Gm-Message-State: APjAAAVJMV/9SA/Y3YS2esefVaXyF91DNVkAKe35/dUM/lDNTAG6Kodi XlvMyvXv9W3O1m47ata1/jSkLQ== X-Google-Smtp-Source: APXvYqxm71bjPQGA+C6RQHjg0XSjGVpYzYAXapOAeU21xKiI0W9WjEeGbAgcnfGQfdcD10NLVm0EDA== X-Received: by 2002:a6b:e008:: with SMTP id z8mr5685029iog.273.1571356754189; Thu, 17 Oct 2019 16:59:14 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i13sm211459iom.54.2019.10.17.16.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Oct 2019 16:59:13 -0700 (PDT) Subject: Re: [PATCH linux-kselftest/test v2] ext4: add kunit test for decoding extended timestamps To: Tim.Bird@sony.com, yzaikin@google.com Cc: tytso@mit.edu, brendanhiggins@google.com, linux-kselftest@vger.kernel.org, linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, kunit-dev@googlegroups.com, Shuah Khan References: <20191010023931.230475-1-yzaikin@google.com> <2f2ea7b0-f683-1cdd-f3f2-ecdf44cb4a97@linuxfoundation.org> <20191011131902.GC16225@mit.edu> <1e6611e6-2fa6-6f7d-bc7f-0bc2243d9342@linuxfoundation.org> <20191017120833.GA25548@mit.edu> <957434b6-32cc-487f-f48e-f9c4416b3f60@linuxfoundation.org> <40073fc9-1de1-9253-e2f9-9cf9ee4308d4@linuxfoundation.org> From: Shuah Khan Message-ID: <00f59a2f-6dd5-f972-47b4-28e5c996c2a5@linuxfoundation.org> Date: Thu, 17 Oct 2019 17:59:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 10/17/19 5:54 PM, Tim.Bird@sony.com wrote: > > >> -----Original Message----- >> From: Iurii Zaikin >> >>> You can do all of this and allow users to supply another set of data. >>> It doesn't gave to be one or the other. >>> >> What is the use case for running a unit test on a different data set than >> what it comes with? > > I just gave some ideas in another message (our emails crossed), > but one use case is to allow someone besides the test author > to inject additional data points, and to do so without having to re-compile > the code. > Right. Test author might not think about all the possible ways to test. > They might do this for multiple reasons: > - to experiment with additional data points > - to try to diagnose a problem they are seeing > - to fill gaps they see in existing data points > Thanks for explaining the scenarios. > Whether this makes sense depends on a lot of factors. I suspect > the timestamp test code is not a good candidate for this, as the code > is simple enough that adding a new test case is pretty trivial. For some > other types of tests, adding the data via an external file could be easier > than changing the code of the test. I agree. Even if author thinks of all the different ways (I am convinced of that), still taking test data at run-time makes the unit test just more effective. thanks, -- Shuah