public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: zhanchengbin <zhanchengbin1@huawei.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, Lukas Czerner <lczerner@redhat.com>,
	<liuzhiqiang26@huawei.com>, linfeilong <linfeilong@huawei.com>
Subject: [PATCH] misc/fsck.c: Processes may kill other processes.
Date: Sat, 8 Oct 2022 11:05:48 +0800	[thread overview]
Message-ID: <01783b8c-2a39-73ec-c537-cc1df82643e2@huawei.com> (raw)

If run the fsck -N command, processes don't execute, just show what
would be done. However, the pid whose value is -1 is added to the
instance_list list in the execute function,if the kill_all function
is called later, kill(-1, signum) is executed, Signals are sent to
all processes except the number one process and itself. Other
processes will be killed if they use the default signal processing
function.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
---
  misc/fsck.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/misc/fsck.c b/misc/fsck.c
index 4efe10ec..faf7789d 100644
--- a/misc/fsck.c
+++ b/misc/fsck.c
@@ -546,6 +546,8 @@ static int kill_all(int signum)
  	for (inst = instance_list; inst; inst = inst->next) {
  		if (inst->flags & FLAG_DONE)
  			continue;
+		if (inst->pid == -1)
+			continue;
  		kill(inst->pid, signum);
  		n++;
  	}
-- 
2.27.0

             reply	other threads:[~2022-10-08  3:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08  3:05 zhanchengbin [this message]
2022-10-10  7:17 ` [PATCH] misc/fsck.c: Processes may kill other processes Lukas Czerner
2022-10-10  8:32   ` zhanchengbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01783b8c-2a39-73ec-c537-cc1df82643e2@huawei.com \
    --to=zhanchengbin1@huawei.com \
    --cc=lczerner@redhat.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox