Re: [RFC][PATCH 0/3] ext4 online defrag (ver 0.2)

["Takashi Sato" <sho@tnes.nec.co.jp>]

Hi,

Thank you for your comment.

>> >>>1. Add new ioctl(EXT4_IOC_DEFRAG) which returns the first physical
>> >>>   block number of the specified file.  With this ioctl, a command
>> >>>   gets the specified directory's.
>> >>
>> >>Maybe I don't understand, but how is this different from the long-time
>> >>FIBMAP ioctl?
>> >
>> >I can use FIBMAP instead of my new ioctl.
>> >You are right.  I should have used FIBMAP ioctl...
>>
>> I have to get the physical block number of the specified directory.
>> But FIBMAP is available only for a regular file, not for a directory.
>> So I will use my new ioctl.
>
> Though it might make sense to implement FIBMAP for a directory, to keep
> it consistent and allow user-space tools like "filefrag" to work on
> directories also.

It sounds good.
I think it will be useful for other tools which use FIBMAP.
So I will consider the implementation of FIBMAP for a directory.

Cheers, Takashi