From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E083E1687 for ; Mon, 25 May 2026 08:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697227; cv=none; b=JE8/NS7NE7cq76wBRwG43+japr2XyY/9/gazhozRsYGVt8IPpxpzq33cU6vjwD4EWMigf2DNycVYZSmjJ2rm07GZTc3GoY0TdltSGCh9DjoR3HAOUjtKxeD58XE1l3rlbepAJ6uqZuzb3TtgS64qUgD9+NW29HmWcpQc0+dqhxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697227; c=relaxed/simple; bh=e8rEW29dCniH2gKK6PkMgFes4ymdMVTdoX5svgA4o5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N651uErScvXysrumKi4JuquDCyDMYFVhbRRtbueWASCTGjUlj8sKvfggwsiQxNMlXrx4TtQdEHp0nv0YOr6anCG1z0/olKTv8/glnPUlqSI0XdI7DbEXOWvh1BG2bFqp0IfsqSCti4uKNLCnptlLZ/Xtt45tsluD0Yw5tZZNPbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A9X0o17Z; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9X0o17Z" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c801912c903so4095179a12.0 for ; Mon, 25 May 2026 01:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779697225; x=1780302025; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rP2XwVbHYZOzOgD0rZjER3jPkSEkCdbeWs9oiQjvBWs=; b=A9X0o17Zr89QqXeFZ+ZRnPmMd2mdJwS5yCF7yiSkMvG81FroLZQXuGSjBdM7ah4Q7+ HH50kzRRnTXkVj9b1mBXISGxmwNJxtnCaaA8kovV/oXbiqjKV4S0alRvDF6fbmS7BEO4 xJPUmMkg8cmyAq+BlQYrnN9ZzD9yjvNyF4XoI7LsxnJmS1RtXYxwUBeqHJszbj007Wmz AWZ6t8MXHhDOKNLct4zlD0+wxXz5z1xle2G7pTGZVk0nNBR1cxCrMILtddJuf5CuwSUQ 38C34iH2ziiDnC5uldEajKL/TJBfV3RlvP7MkmSGy+jSTzJqjDmS8AH339dS6DnKm8GE KWyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779697225; x=1780302025; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rP2XwVbHYZOzOgD0rZjER3jPkSEkCdbeWs9oiQjvBWs=; b=eowNcUZACRV4MRBQOvCgeUxqC++8WzdPI4yI0rlDx7nFXi3Uj/BcNE6By5S8yJp8ex QIa6MobGvCHr8ckuvwJB1OcSctVBASyoo3lqQCkqqjkWVtGZKUH9uxLz1AfPOGBImHF5 FNjIlfx3GbnzFbpfsFi2xv1RURIC0HwVQPDJK+rrFsoXGusUzf2KQ5DvA5LAhEbuNuUQ xifoV8BZ/KPjsG7AvyWNzUEK+lCSq63ntxhtBqQpRwz3lw5GBQM0eqYgszMAWRqEO4Kv sLSaJXUwsqMDkXV725/Dv2dx90djSsCW4snr5UuOQIlhavIJiCRGtcQSqZCIwL67HkFT QzEQ== X-Forwarded-Encrypted: i=1; AFNElJ+1UxvEB+MNXZ0GLb8Mc/JE3tY6qykY5qapKcvVft59Qb69NFV0RrjiE/L4UpuPHqPIe0BF/zKgc3Gt@vger.kernel.org X-Gm-Message-State: AOJu0YzMvlBJ6AjyiqCJzzg953cTwq/XvepPK4fHgp5rUnqash+zsy57 P/pYORtbLX6twfzcRVmp/MA9lrk6ClYV0uSiTAKvgZe/Zz6fvfBQ/0ia X-Gm-Gg: Acq92OHYWr/A/ie3p9Nh7ZyGQOTRUnSzTfVjoIeWWnbmpF+32xQgdQQwa5fv3sWfFT4 oqgt1gECMH/yWv8cZl5ilIa7y3F+c1lqfQPBCrFp1KG1EM42/TsgyuZm5m8Tm0PMZbTUIOtlKOC W1xDNDvcFesTx70cosXTxrrTTo5TELgKqTsSFOtFZ+s6Ke24clrENkE+jnzjhoVwZFqFkHKOqJE EJpnejGp0t5KxIlqg1k+lKPG3u1lz4nXEFaqnGnBuXfyYSBcodsOkikd5wI3t5TXHSzTke2PvrD huLIolCfiGNPD2tkqt/w3PZzIYrnmAVR4obi4MvE1Q0uJrGyej7n3lJWvLCjGif92eD8GNxVg9A PQx69BZvRewYpJOBwTPpzg4QIcTM3vPST6iLyoIr80+15SMegQ31VLyl0lzhp7zZQvCYv8hKQ5V P0Uvdq8uB5CRwUNh4KosHpFQORBno= X-Received: by 2002:a05:6a20:3c8e:b0:3aa:55eb:a5fb with SMTP id adf61e73a8af0-3b328d15f18mr14912245637.23.1779697225436; Mon, 25 May 2026 01:20:25 -0700 (PDT) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852056d767sm7212551a12.25.2026.05.25.01.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 01:20:25 -0700 (PDT) Message-ID: <0f774a12-7355-45de-bf95-4c98193d4727@gmail.com> Date: Mon, 25 May 2026 16:20:21 +0800 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/10] fstests: verify fanotify isolation on cloned filesystems To: Christoph Hellwig , Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, amir73il@gmail.com, zlang@redhat.com References: Content-Language: en-US From: Anand Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/5/26 15:11, Christoph Hellwig wrote: >> +export FSNOTIFYWAIT_PROG="$(type -P fsnotifywait)" > > Same comment about adding new common bits outside of test cases applies, Got it. > but why use both inotify and fsnotify? > The SYSCALL and stuffs until fsnotify_..() are different, so I decided to keep them both. >> +[[ "$fsid1" == "$fsid2" ]] && \ >> + _notrun "Require clone filesystem with unique f_fsid" > > Please add a comment why this happens. I also have to say I find > the if syntax easier to follow then && with a line continuation. Got it. If statements are better for readability. Also, I'll add comments.