From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B193CC31E4B for ; Thu, 13 Jun 2019 16:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94DA920449 for ; Thu, 13 Jun 2019 16:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389651AbfFMQdX (ORCPT ); Thu, 13 Jun 2019 12:33:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33264 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730818AbfFMIDy (ORCPT ); Thu, 13 Jun 2019 04:03:54 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 6065A83989627B163AFF; Thu, 13 Jun 2019 16:03:51 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Jun 2019 16:03:48 +0800 Subject: =?UTF-8?Q?Re:_=e5=9b=9e=e5=a4=8d:_[PATCH_2/2]_f2fs:_only_set_projec?= =?UTF-8?Q?t_inherit_bit_for_directory?= To: Wang Shilong , Wang Shilong , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" CC: Andreas Dilger References: <1559795545-17290-1-git-send-email-wshilong1991@gmail.com> <1559795545-17290-2-git-send-email-wshilong1991@gmail.com> <73fb9e88-d3f5-9420-d6d8-82ff4354e4d6@huawei.com> From: Chao Yu Message-ID: <110862e6-fd2a-b580-fec8-18a9b351ecb1@huawei.com> Date: Thu, 13 Jun 2019 16:03:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2019/6/13 15:34, Wang Shilong wrote: > Hi Chao, > > I just sent a V2, but I think we'd better do that when reading inode, for two reasons: > > 1) not only F2FS_IOC_GETFLAGS need filter flags but also F2FS_IOC_FSGETXATTR need that, so the amended parts is not enough IMO. > > 2) doing that by reading inode give a benefit that we could correct on disk flags for regular file next dirtying inode happen. Hi Shilong, agreed, I'm okay with that change. :) Thanks,