From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: akpm@osdl.org, lkml <linux-kernel@vger.kernel.org>,
ext4 <linux-ext4@vger.kernel.org>,
Will Simoneau <simoneau@ele.uri.edu>,
cmm@us.ibm.com
Subject: Re: [PATCH] ext3_getblk should handle HOLE correctly
Date: Wed, 06 Sep 2006 12:42:55 -0500 [thread overview]
Message-ID: <1157564575.8200.16.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <1157564346.23501.49.camel@dyn9047017100.beaverton.ibm.com>
On Wed, 2006-09-06 at 10:39 -0700, Badari Pulavarty wrote:
> Index: linux-2.6.18-rc5/fs/ext3/inode.c
> ===================================================================
> --- linux-2.6.18-rc5.orig/fs/ext3/inode.c 2006-08-27 20:41:48.000000000 -0700
> +++ linux-2.6.18-rc5/fs/ext3/inode.c 2006-09-05 15:32:57.000000000 -0700
> @@ -1009,11 +1009,12 @@ struct buffer_head *ext3_getblk(handle_t
> buffer_trace_init(&dummy.b_history);
> err = ext3_get_blocks_handle(handle, inode, block, 1,
> &dummy, create, 1);
> - if (err == 1) {
> + /*
> + * ext3_get_blocks_handle() returns number of blocks
> + * mapped. 0 in case of a HOLE.
> + */
> + if (err > 0) {
> err = 0;
> - } else if (err >= 0) {
> - WARN_ON(1);
> - err = -EIO;
> }
I'd get rid of the {} too.
> *errp = err;
> if (!err && buffer_mapped(&dummy)) {
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2006-09-06 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 17:39 [PATCH] ext3_getblk should handle HOLE correctly Badari Pulavarty
2006-09-06 17:42 ` Dave Kleikamp [this message]
2006-09-07 18:45 ` Andrew Morton
2006-09-07 19:22 ` Badari Pulavarty
2006-09-07 19:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157564575.8200.16.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=simoneau@ele.uri.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox