linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mingming Cao <cmm@us.ibm.com>
To: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>
Cc: Mel Gorman <mel@skynet.ie>, "Martin J. Bligh" <mbligh@mbligh.org>,
	linux-kernel@vger.kernel.org,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: [PATCH 10/12] ext4 balloc: say rb_entry not list_entry
Date: Tue, 28 Nov 2006 20:15:24 -0800	[thread overview]
Message-ID: <1164773724.4341.44.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0611281742470.29701@blonde.wat.veritas.com>


------------------------------------------------------
Subject: ext2 balloc: say rb_entry not list_entry
From: Hugh Dickins <hugh@veritas.com>

The reservations tree is an rb_tree not a list, so it's less confusing to use
rb_entry() than list_entry() - though they're both just container_of().

----------------------------------------------------------

Sync up this fix in ext4

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
---


---

 linux-2.6.19-rc5-cmm/fs/ext4/balloc.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN fs/ext4/balloc.c~ext4-balloc-say-rb_entry-not-list_entry fs/ext4/balloc.c
--- linux-2.6.19-rc5/fs/ext4/balloc.c~ext4-balloc-say-rb_entry-not-list_entry	2006-11-28 19:37:08.000000000 -0800
+++ linux-2.6.19-rc5-cmm/fs/ext4/balloc.c	2006-11-28 19:37:08.000000000 -0800
@@ -165,7 +165,7 @@ restart:
 
 	printk("Block Allocation Reservation Windows Map (%s):\n", fn);
 	while (n) {
-		rsv = list_entry(n, struct ext4_reserve_window_node, rsv_node);
+		rsv = rb_entry(n, struct ext4_reserve_window_node, rsv_node);
 		if (verbose)
 			printk("reservation window 0x%p "
 			       "start:  %llu, end:  %llu\n",
@@ -966,7 +966,7 @@ static int find_next_reservable_window(
 
 		prev = rsv;
 		next = rb_next(&rsv->rsv_node);
-		rsv = list_entry(next,struct ext4_reserve_window_node,rsv_node);
+		rsv = rb_entry(next,struct ext4_reserve_window_node,rsv_node);
 
 		/*
 		 * Reached the last reservation, we can just append to the
@@ -1210,7 +1210,7 @@ static void try_to_extend_reservation(st
 	if (!next)
 		my_rsv->rsv_end += size;
 	else {
-		next_rsv = list_entry(next, struct ext4_reserve_window_node, rsv_node);
+		next_rsv = rb_entry(next, struct ext4_reserve_window_node, rsv_node);
 
 		if ((next_rsv->rsv_start - my_rsv->rsv_end - 1) >= size)
 			my_rsv->rsv_end += size;

_

  parent reply	other threads:[~2006-11-29  4:15 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061114014125.dd315fff.akpm@osdl.org>
     [not found] ` <20061114184919.GA16020@skynet.ie>
     [not found]   ` <Pine.LNX.4.64.0611141858210.11956@blonde.wat.veritas.com>
     [not found]     ` <20061114113120.d4c22b02.akpm@osdl.org>
     [not found]       ` <Pine.LNX.4.64.0611142111380.19259@blonde.wat.veritas.com>
     [not found]         ` <Pine.LNX.4.64.0611151404260.11929@blonde.wat.veritas.com>
2006-11-16  5:45           ` Boot failure with ext2 and initrds Andrew Morton
2006-11-16  6:39             ` Andrew Morton
2006-11-16  6:55             ` Mingming Cao
2006-11-16  7:22               ` Andrew Morton
2006-11-16  8:49                 ` Mingming Cao
2006-11-16  9:13                   ` Andrew Morton
2006-11-16  9:37                     ` Alex Tomas
2006-11-16  9:48                       ` Andrew Morton
2006-11-16  9:49                         ` Andrew Morton
2006-11-16 16:26                     ` Hugh Dickins
2006-11-16 20:15                     ` Mingming Cao
2006-11-16 21:27                       ` Andrew Morton
2006-11-20 16:19                         ` Hugh Dickins
2006-11-20 20:54                           ` Hugh Dickins
2006-11-21  1:36                             ` Mingming Cao
2006-11-21  1:47                           ` Mingming Cao
2006-11-21  5:39                             ` Hugh Dickins
2006-11-22  0:43                               ` Mingming Cao
2006-11-28 17:38                                 ` Hugh Dickins
2006-11-28 17:40                                   ` [PATCH 1/6] ext2 balloc: fix _with_rsv freeze Hugh Dickins
2006-11-28 19:26                                     ` Mingming Cao
2006-11-28 20:07                                       ` Hugh Dickins
2006-11-29  0:42                                         ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 6/12] " Mingming Cao
2006-11-29  4:15                                     ` [PATCH 12/12] ext3 " Mingming Cao
2006-11-28 17:40                                   ` [PATCH 2/6] ext2 balloc: reset windowsz when full Hugh Dickins
2006-11-28 19:36                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 2/12] ext3 balloc: fix off-by-one against grp_goal Mingming Cao
2006-11-29  4:15                                     ` [PATCH 8/12] ext4 " Mingming Cao
2006-11-28 17:41                                   ` [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end Hugh Dickins
2006-11-28 19:42                                     ` Mingming Cao
2006-11-28 17:42                                   ` [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal Hugh Dickins
2006-11-28 23:30                                     ` Mingming Cao
2006-11-29  4:13                                     ` [PATCH 1/12] ext3 balloc: reset windowsz when full Mingming Cao
2006-11-29  5:46                                       ` Hugh Dickins
2006-11-29  4:14                                     ` [PATCH 3/12] ext3 balloc: fix off-by-one against rsv_end Mingming Cao
2006-11-29  4:14                                     ` [PATCH 7/12] ext4 balloc: reset windowsz when full Mingming Cao
2006-11-29  4:15                                     ` [PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end Mingming Cao
2006-11-28 17:43                                   ` [PATCH 5/6] ext2 balloc: say rb_entry not list_entry Hugh Dickins
2006-11-28 23:30                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 4/12] ext3 " Mingming Cao
2006-11-29  4:15                                     ` Mingming Cao [this message]
2006-11-28 17:44                                   ` [PATCH 6/6] ext2 balloc: use io_error label Hugh Dickins
2006-11-28 23:31                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 5/12] ext3 " Mingming Cao
2006-11-29  4:15                                     ` [PATCH 11/12] ext4 " Mingming Cao
2006-11-28 21:04                                   ` Boot failure with ext2 and initrds Mingming Cao
2006-11-28 22:33                                     ` Andrew Morton
2006-11-28 23:38                                       ` Mingming Cao
2006-11-16 12:34                 ` Russell King
2006-11-25 14:59                   ` Russell King
2006-11-29  7:40                     ` Russell King
2006-11-29  8:30                       ` Andrew Morton
2006-11-29  9:20                         ` Russell King
2006-11-29  9:39                           ` Andrew Morton
2006-11-29 18:16                             ` Russell King
2006-11-20  2:24 ` [-mm patch] make ext2_get_blocks() static Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164773724.4341.44.camel@localhost.localdomain \
    --to=cmm@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@mbligh.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).