Re: [Resubmit][PATCH 5/5] Secure Deletion and Trash-Bin Support for Ext4

[Dave Kleikamp <shaggy@linux.vnet.ibm.com>]

On Thu, 2007-02-01 at 06:05 -0500, Harry Papaxenopoulos wrote:
> 
> On Wed, 31 Jan 2007, Dave Kleikamp wrote:

> > why not unconditionally goto out here?  if vfs_trash_entry() was
> > successful, the file was successfully moved to the trashbin directory.
> > There is nothing left to be done, right?  Then there's no need for the
> > trashed flag.
> >
> > In fact, the ifdef'ed code should precede the call to get_UCSname(),
> > since we don't need to allocate dname if we move the file to the
> > trashbin, and we leak the allocation if we jump to out:.
> >
> 
> Well the main reason I don't jump to out is to update the inode's
> change time, otherwise I would have unconditionally jumped.

the rename already updates the change time.
> 
> You're right, I used the incorrect label to jump. Should have been "out1"
> instead of "out" so the allocation is freed. Sorry about that.

I'd rather do the allocation after the new code anyway.  It's not needed
at all if we're moving the file to the trashbin.

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center