Re: avoid leak upon failed realloc

Jeremy Allison
2007-06-22T17:27:04Z

On Fri, Jun 22, 2007 at 02:41:44AM -0400, Theodore Tso wrote:
> On Mon, Jun 18, 2007 at 04:10:44PM +0200, Jim Meyering wrote:
> > Here's a tiny fix to avoid a leak when realloc fails:
> >
> > 2007-06-16 Jim Meyering <jim@meyering.net>
> >
> > * tdb.c (tdb_append): Don't leak a buffer when realloc fails.
>
> Hi Jim,
>
> Thanks for the patch! I actually automatically build the
> tdb.c file from the Samba SVN tree (with a series of patches and
> scripts) at:
>
> svn://svnanon.samba.org/samba/branches/SAMBA_4_0/source/lib/tdb
>
> So I'm going to forward this patch (attached) to the Samba developers.
> It appears to apply cleanly to .../source/lib/tdb/common/tdb.c. Once
> they commit it into their SVN tree, I can just pick it up from there.

Thanks Ted, we fixed this in the generic Samba sources by using
realloc wrappers, but tdb has to be separate from these.

I'll commit the fix asap.

Thanks,

Jeremy.