From: Girish Shilamkar <girish@linsyssoft.com>
To: Ext4 Mailing List <linux-ext4@vger.kernel.org>
Cc: Andreas Dilger <adilger@clusterfs.com>,
Theodore Tso <tytso@mit.edu>, Mingming Cao <cmm@us.ibm.com>
Subject: Re: [PATCH] Journal Checksum - rebased to 2.6.22-rc5
Date: Tue, 26 Jun 2007 16:17:30 +0530 [thread overview]
Message-ID: <1182854850.3041.16.camel@dhcp7.linsyssoft.com> (raw)
In-Reply-To: <1182504986.3788.18.camel@dhcp7.linsyssoft.com>
On Fri, 2007-06-22 at 15:06 +0530, Girish Shilamkar wrote:
> Hi,
> The previous patch was an old one. Hence I am sending the latest patch
> rebased to 2.6.22-rc5. I have also fixed few coding style issues in both
> the patches.
>
> Regards,
> Girish
This patch had a bug. Thanks to Valerie for pointing it out.
Regards,
Girish.
Index: linux-2.6.22-rc5/fs/jbd2/commit.c
===================================================================
--- linux-2.6.22-rc5.orig/fs/jbd2/commit.c
+++ linux-2.6.22-rc5/fs/jbd2/commit.c
@@ -121,8 +121,8 @@ static int journal_submit_commit_record(
bh = jh2bh(descriptor);
for (i = 0; i < bh->b_size; i += 512) {
- struct commit_header *tmp = (struct commit_header *)bh->b_data +
- i;
+ struct commit_header *tmp = (struct commit_header *)(bh->b_data+
+ i);
tmp->h_magic = cpu_to_be32(JBD2_MAGIC_NUMBER);
tmp->h_blocktype = cpu_to_be32(JBD2_COMMIT_BLOCK);
tmp->h_sequence = cpu_to_be32(commit_transaction->t_tid);
next prev parent reply other threads:[~2007-06-26 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 9:36 [PATCH] Journal Checksum - rebased to 2.6.22-rc5 Girish Shilamkar
2007-06-22 16:05 ` Dave Kleikamp
2007-06-23 5:43 ` Girish Shilamkar
2007-06-26 10:47 ` Girish Shilamkar [this message]
2007-06-26 14:13 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182854850.3041.16.camel@dhcp7.linsyssoft.com \
--to=girish@linsyssoft.com \
--cc=adilger@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox