From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@osdl.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Faster ext2_clear_inode()
Date: Mon, 09 Jul 2007 17:02:20 -0500 [thread overview]
Message-ID: <1184018540.6820.5.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <20070709200003.GA18501@lazybastard.org>
On Mon, 2007-07-09 at 22:00 +0200, Jörn Engel wrote:
> On Mon, 9 July 2007 22:01:48 +0400, Alexey Dobriyan wrote:
> >
> > Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
> > empty, it leaves traces in resulting kernel.
>
> Is that your opinion or have you actually measured a difference?
> I strongly suspect that compilers are smart enough to optimize away a
> call to an empty static function.
It's not a direct call to a static function. It is called as a
super_ops method. I don't think the overhead is very significant, but
it doesn't look like it could do any harm.
--
David Kleikamp
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-07-09 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 4:11 [PATCH] Faster ext2_clear_inode() Alexey Dobriyan
2007-07-09 8:34 ` Jörn Engel
2007-07-09 18:01 ` Alexey Dobriyan
2007-07-09 20:00 ` Jörn Engel
2007-07-09 22:02 ` Dave Kleikamp [this message]
2007-07-09 22:12 ` Jörn Engel
2007-07-20 0:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184018540.6820.5.camel@kleikamp.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=joern@logfs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).