From: Kalpak Shah <kalpak@clusterfs.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@clusterfs.com>
Subject: Re: [e2fsprogs] Bug in salvage_directory
Date: Tue, 10 Jul 2007 12:17:32 +0530 [thread overview]
Message-ID: <1184050052.4440.2.camel@garfield> (raw)
In-Reply-To: <20070709230234.GE2343@thunk.org>
On Mon, 2007-07-09 at 19:02 -0400, Theodore Tso wrote:
> On Mon, Jul 09, 2007 at 11:22:05PM +0530, Kalpak Shah wrote:
> > Yes even prev->rec_len cannot be beyond fs->blocksize. I do have the
> > corrupt filesystem image but it is a large one.
> >
> > This patch certainly works well and corrects the problem in a single run
> > of e2fsck.
>
> When you say "this patch", I assume you meant the patch I wrote as
> opposed to the one you submitted, right?
Yes, I meant the patch you wrote.
Thanks,
Kalpak.
> In any case, I've created a
> test case (attached) which is fixed in a single run of e2fsck, but
> which your patch requires two runs to fix.
>
> So I will be committing my patch into the tree.
>
> Regards,
>
> - Ted
>
>
>
prev parent reply other threads:[~2007-07-10 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 9:32 [e2fsprogs] Bug in salvage_directory Kalpak Shah
2007-07-09 16:50 ` Theodore Tso
2007-07-09 17:52 ` Kalpak Shah
2007-07-09 18:29 ` Theodore Tso
2007-07-09 19:17 ` Andreas Dilger
2007-07-09 20:20 ` Theodore Tso
[not found] ` <20070709230234.GE2343@thunk.org>
2007-07-10 6:47 ` Kalpak Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184050052.4440.2.camel@garfield \
--to=kalpak@clusterfs.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).