From: Mingming Cao <cmm@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Theodore Tso <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev
Date: Tue, 10 Jul 2007 17:35:13 -0400 [thread overview]
Message-ID: <1184103313.3759.44.camel@localhost.localdomain> (raw)
In-Reply-To: <20070710163015.ab40ed2a.akpm@linux-foundation.org>
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote:
> On Sun, 01 Jul 2007 03:36:01 -0400
> Mingming Cao <cmm@us.ibm.com> wrote:
>
> > Turn on extents feature by default in ext4 filesystem. User could use
> > -o noextents to turn it off.
> >
>
> Oh, there you go.
>
> >
> > Index: linux-2.6.22-rc4/fs/ext4/super.c
> > ===================================================================
> > --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700
> > +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700
> > @@ -1546,6 +1546,12 @@
> >
> > set_opt(sbi->s_mount_opt, RESERVATION);
> >
> > + /*
> > + * turn on extents feature by default in ext4 filesystem
> > + * User -o noextents to turn it off
> > + */
> > + set_opt (sbi->s_mount_opt, EXTENTS);
> > +
>
> Broken coding style.
>
> Please feed all the ext4 patches through scripts/checkpatch.pl (preferably
> version 0.07 - see Andy's patch on lkml) and then consider addressing the
> (quite large) number of mistakes which are detected.
>
Sorry about this. I was using version 0.04. The latest one I can find
for now is 0.05(searching lkml), but it didn't catch this codling style
bug either. I appreciate if anyone can point me the version 0.07, thanks
Mingming
next prev parent reply other threads:[~2007-07-11 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:36 [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev Mingming Cao
2007-07-10 23:30 ` Andrew Morton
2007-07-10 21:35 ` Mingming Cao [this message]
2007-07-11 3:35 ` Dave Jones
2007-07-11 3:15 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184103313.3759.44.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).