Re: [PATCH 2/4] e2fsprogs: Add undoe2fs

[Kalpak Shah <kalpak@clusterfs.com>]

On Wed, 2007-08-01 at 11:46 +0530, Aneesh Kumar K.V wrote:
> 
> Andreas Dilger wrote:
> > On Aug 01, 2007  07:34 +0530, Aneesh Kumar K.V wrote:
> >> undoe2fs can be used to replay the transaction saved
> >> in the transaction file using undo I/O Manager
> > 
> > This should save the mtime of the superblock, and only do the undo
> > step if the filesystem hasn't changed.  Otherwise it could seriously
> > corrupt the filesystem.
> 
> 
> I am not sure i understand this. The Undo I/O manager tracks all the write
> happening to the file system and copy the original content of the blocks to
> the tdb file. Undoe2fs simply copies these blocks back to the file system. So
> That way if you look at undoe2fs it doesn't have any knowledge of the file
> system at all.
> 
> Can you let me know a use case where this will fail.

undoe2fs made a copy of all the changes to the filesystem. After that
the filesystem was mounted and used thereby rendering the checkpoint
invalid. If this checkpoint was replayed it could seriously corrupt the
filesystem. Hence as Andreas suggests the mtime of the filesystem should
be checked and only then the transaction should be replayed.

Infact mounting the filesystem when the replay is in progress would also
corrupt the filesystem.

Is should the checkpoint be deleted if e2fsck was aborted?

Thanks,
Kalpak.