Re: [PATCH] JBD slab cleanups

Mingming Cao
2007-09-19T20:47:20Z

On Wed, 2007-09-19 at 19:28 +0000, Dave Kleikamp wrote:
> On Wed, 2007-09-19 at 14:26 -0500, Dave Kleikamp wrote:
> > On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote:
> >
> > > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all
> > > cases except one handles memory allocation failure so I get rid of those
> > > GFP_NOFAIL flags.
> > >
> > > Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc
> > > in jbd/jbd2? I will send a separate patch to cleanup that.
> >
> > No. GFP_NOFS avoids deadlock. It prevents the allocation from making
> > recursive calls back into the file system that could end up blocking on
> > jbd code.
>
> Oh, I see your patch now. You mean use GFP_NOFS instead of
> GFP_KERNEL. :-) OK then.
>

oops, I did mean what you say here.:-)

> > Shaggy