Re: [RFC 1/2] JBD: slab management support for large block(>8k)

Christoph Hellwig
2007-09-03T13:40:55Z

On Mon, Sep 03, 2007 at 12:55:04AM -0700, Christoph Lameter wrote:
> On Sun, 2 Sep 2007, Christoph Hellwig wrote:
>
> > > We are doing what you describe right now. So the current code is broken?
> > Yes.
>
> How about getting rid of the slabs there and use kmalloc? Kmalloc in mm
> (and therfore hopefully 2.6.24) will convert kmallocs > PAGE_SIZE to page
> allocator calls. Not sure what to do about the 1k and 2k requests though.

The problem is that we must never use kmalloc pages, so we always need
to request a page or more for these. Better to use get_free_page directly,
that's how I fixed it in XFS a while ago.