Re: [RFC 1/2] JBD: slab management support for large block(>8k)

Christoph Hellwig
2007-09-02T15:28:09Z

On Sun, Sep 02, 2007 at 04:40:21AM -0700, Christoph Lameter wrote:
> On Sat, 1 Sep 2007, Christoph Hellwig wrote:
>
> > On Fri, Aug 31, 2007 at 05:12:18PM -0700, Mingming Cao wrote:
> > > >From clameter:
> > > Teach jbd/jbd2 slab management to support >8k block size. Without this, it refused to mount on >8k ext3.
> >
> >
> > But the real fix is to kill this code. We can't send down slab pages
> > down the block layer without breaking iscsi or aoe. And this code is
> > only used in so rare cases that all the normal testing won't hit it.
> > Very bad combination.
>
> We are doing what you describe right now. So the current code is broken?

Yes.