Re: [PATCH] JBD slab cleanups

Dave Kleikamp
2007-09-19T19:26:31Z

On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote:

> Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all
> cases except one handles memory allocation failure so I get rid of those
> GFP_NOFAIL flags.
>
> Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc
> in jbd/jbd2? I will send a separate patch to cleanup that.

No. GFP_NOFS avoids deadlock. It prevents the allocation from making
recursive calls back into the file system that could end up blocking on
jbd code.

Shaggy
--
David Kleikamp
IBM Linux Technology Center