From: Mingming Cao <cmm@us.ibm.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
valerie.clement@bull.net, linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: Sparse endian issues with patches.
Date: Wed, 12 Sep 2007 17:36:31 -0700 [thread overview]
Message-ID: <1189643792.11977.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20070913003258.GR5377@schatzie.adilger.int>
On Wed, 2007-09-12 at 18:32 -0600, Andreas Dilger wrote:
> On Sep 12, 2007 22:18 +0530, Aneesh Kumar K.V wrote:
> > Attaching below patch that fix the sparse warning for ext4.
>
> It would be good to also fix the "raw" access of split 48-bit and 64-bit
> fields as I previously sent to the list. A new typedef for these fields
> (on disk) would ensure that they are not accessed directly and give
> compiler warnings if new patches don't have the right macro usage.
>
> > - if (mnt_count != sbi->s_es->s_mnt_count) {
> > + if (mnt_count != le16_to_cpu(sbi->s_es->s_mnt_count)) {
>
> That overflows 80 columns, as do several other lines.
> >
>
checkpatch.pl should catched this... The version in ext4-patch queue
should be clean now.
> Cheers, Andreas
> --
> Andreas Dilger
> Principal Software Engineer
> Cluster File Systems, Inc.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-09-13 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 16:48 Sparse endian issues with patches Aneesh Kumar K.V
2007-09-13 0:32 ` Andreas Dilger
2007-09-13 0:36 ` Mingming Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189643792.11977.2.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=adilger@clusterfs.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=valerie.clement@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox