From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: [PATCH] ext4: Convert s_blocks_count to s_blocks_count_lo Date: Thu, 4 Oct 2007 01:50:55 -0400 Message-ID: <1191477059-5357-21-git-send-email-tytso@mit.edu> References: <1191477059-5357-1-git-send-email-tytso@mit.edu> <1191477059-5357-2-git-send-email-tytso@mit.edu> <1191477059-5357-3-git-send-email-tytso@mit.edu> <1191477059-5357-4-git-send-email-tytso@mit.edu> <1191477059-5357-5-git-send-email-tytso@mit.edu> <1191477059-5357-6-git-send-email-tytso@mit.edu> <1191477059-5357-7-git-send-email-tytso@mit.edu> <1191477059-5357-8-git-send-email-tytso@mit.edu> <1191477059-5357-9-git-send-email-tytso@mit.edu> <1191477059-5357-10-git-send-email-tytso@mit.edu> <1191477059-5357-11-git-send-email-tytso@mit.edu> <1191477059-5357-12-git-send-email-tytso@mit.edu> <1191477059-5357-13-git-send-email-tytso@mit.edu> <1191477059-5357-14-git-send-email-tytso@mit.edu> <1191477059-5357-15-git-send-email-tytso@mit.edu> <1191477059-5357-16-git-send-email-tytso@mit.edu> <1191477059-5357-17-git-send-email-tytso@mit.edu> <1191477059-5357-18-git-send-email-tytso@mit.edu> <1191477059-5357-19-git-send-email-tytso@mit.edu> <1191477059-5357-20-git-send-email-tytso@mit.edu> Cc: linux-ext4@vger.kernel.org, "Aneesh Kumar K.V" To: linux-kernel@vger.kernel.org Return-path: Received: from THUNK.ORG ([69.25.196.29]:44818 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753266AbXJDFvK (ORCPT ); Thu, 4 Oct 2007 01:51:10 -0400 In-Reply-To: <1191477059-5357-20-git-send-email-tytso@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org From: Aneesh Kumar K.V Convert s_blocks_count to s_blocks_count_lo This helps in finding BUGs due to direct partial access of these split 64 bit values Also fix direct partial access in ext4 code Signed-off-by: Aneesh Kumar K.V --- fs/ext4/super.c | 4 ++-- include/linux/ext4_fs.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 7548408..dc7fe4c 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2593,7 +2593,7 @@ static int ext4_statfs (struct dentry * dentry, struct kstatfs * buf) if (test_opt(sb, MINIX_DF)) { sbi->s_overhead_last = 0; - } else if (sbi->s_blocks_last != le32_to_cpu(es->s_blocks_count)) { + } else if (sbi->s_blocks_last != ext4_blocks_count(es)) { unsigned long ngroups = sbi->s_groups_count, i; ext4_fsblk_t overhead = 0; smp_rmb(); @@ -2628,7 +2628,7 @@ static int ext4_statfs (struct dentry * dentry, struct kstatfs * buf) overhead += ngroups * (2 + sbi->s_itb_per_group); sbi->s_overhead_last = overhead; smp_wmb(); - sbi->s_blocks_last = le32_to_cpu(es->s_blocks_count); + sbi->s_blocks_last = ext4_blocks_count(es); } buf->f_type = EXT4_SUPER_MAGIC; diff --git a/include/linux/ext4_fs.h b/include/linux/ext4_fs.h index 5eb4953..339412d 100644 --- a/include/linux/ext4_fs.h +++ b/include/linux/ext4_fs.h @@ -501,7 +501,7 @@ do { \ */ struct ext4_super_block { /*00*/ __le32 s_inodes_count; /* Inodes count */ - __le32 s_blocks_count; /* Blocks count */ + __le32 s_blocks_count_lo; /* Blocks count */ __le32 s_r_blocks_count; /* Reserved blocks count */ __le32 s_free_blocks_count; /* Free blocks count */ /*10*/ __le32 s_free_inodes_count; /* Free inodes count */ @@ -1001,7 +1001,7 @@ extern void ext4_inode_table_set(struct super_block *sb, static inline ext4_fsblk_t ext4_blocks_count(struct ext4_super_block *es) { return ((ext4_fsblk_t)le32_to_cpu(es->s_blocks_count_hi) << 32) | - le32_to_cpu(es->s_blocks_count); + le32_to_cpu(es->s_blocks_count_lo); } static inline ext4_fsblk_t ext4_r_blocks_count(struct ext4_super_block *es) @@ -1019,7 +1019,7 @@ static inline ext4_fsblk_t ext4_free_blocks_count(struct ext4_super_block *es) static inline void ext4_blocks_count_set(struct ext4_super_block *es, ext4_fsblk_t blk) { - es->s_blocks_count = cpu_to_le32((u32)blk); + es->s_blocks_count_lo = cpu_to_le32((u32)blk); es->s_blocks_count_hi = cpu_to_le32(blk >> 32); } -- 1.5.3.2.81.g17ed