From: Mingming Cao <cmm@us.ibm.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>, johann.lombardi@bull.net
Subject: Re: [PATCH] Fix oops with jbd-stats-through-procfs and external journal
Date: Thu, 25 Oct 2007 12:24:06 -0700 [thread overview]
Message-ID: <1193340246.4288.3.camel@localhost.localdomain> (raw)
In-Reply-To: <4720C6DC.7010803@redhat.com>
Thanks, Added to ext4 patch queue at
http://repo.or.cz/w/ext4-patch-queue.git
On Thu, 2007-10-25 at 11:39 -0500, Eric Sandeen wrote:
> When using an external device for the journal,
> jbd2_stats_proc_init() wants to use journal->j_dev in its call
> to bdevname() but it's not assigned yet, resulting in an oops.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> --- linux.orig/fs/jbd2/journal.c 2007-10-25 11:36:25.772354262 -0500
> +++ linux/fs/jbd2/journal.c 2007-10-25 11:36:35.058278242 -0500
> @@ -1035,11 +1035,11 @@
> journal = NULL;
> goto out;
> }
> - jbd2_stats_proc_init(journal);
> journal->j_dev = bdev;
> journal->j_fs_dev = fs_dev;
> journal->j_blk_offset = start;
> journal->j_maxlen = len;
> + jbd2_stats_proc_init(journal);
>
> bh = __getblk(journal->j_dev, start, journal->j_blocksize);
> J_ASSERT(bh != NULL);
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-10-25 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 16:39 [PATCH] Fix oops with jbd-stats-through-procfs and external journal Eric Sandeen
2007-10-25 19:24 ` Mingming Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193340246.4288.3.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=johann.lombardi@bull.net \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).