Re: [PATCH] Shrink ext3_inode_info by 8 bytes for !POSIX_ACL.

Indan Zupancic
2008-01-18T23:51:32Z

On Fri, January 18, 2008 20:16, Mingming Cao wrote:
> On Sat, 2008-01-12 at 21:35 +0100, Indan Zupancic wrote:
>> i_file_acl and i_dir_acl aren't always needed.
>>
>> With certain configs this makes 10 ext3_inode_cache objects fit in
>> one slab instead of the current 9, as the size shrinks from 416 to
>> 408 bytes for 32 bit, !POSIX_ACL and !EXT3_FS_XATTR configs.
>>
>> Signed-off-by: Indan Zupancic <indan@nul.nu>
>> ---
>> fs/ext3/ialloc.c | 2 ++
>> fs/ext3/inode.c | 29 +++++++++++++++++++----------
>> include/linux/ext3_fs_i.h | 2 ++
>> 3 files changed, 23 insertions(+), 10 deletions(-)
>>
>> diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
>> index 1bc8cd8..01745bc 100644
>> --- a/fs/ext3/ialloc.c
>> +++ b/fs/ext3/ialloc.c
>> @@ -574,8 +574,10 @@ got:
>> ei->i_frag_no = 0;
>> ei->i_frag_size = 0;
>> #endif
>> +#ifdef CONFIG_EXT3_FS_POSIX_ACL
>> ei->i_file_acl = 0;
>> ei->i_dir_acl = 0;
>> +#endif
>
> For regular file, i_dir_acl is being reused as i_size_high to support
> large file.

Only the i_dir_acl of struct ext3_inode, not the one from ext3_inode_info.

Thanks,

Indan