From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: "Theodore Ts'o" <tytso@MIT.EDU>
Cc: linux-ext4@vger.kernel.org, Mingming Cao <cmm@us.ibm.com>,
Takashi Sato <t-sato@yk.jp.nec.com>,
Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: Re: ext4-online-defrag-free-space-fragmentation.patch uses do_fsync()
Date: Wed, 23 Jan 2008 08:10:20 -0600 [thread overview]
Message-ID: <1201097420.9082.5.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <E1JHg4T-0007lQ-8f@closure.thunk.org>
> diff --git a/fs/ext4/defrag.c b/fs/ext4/defrag.c
> index 4ef3dc0..19d2cfd 100644
> --- a/fs/ext4/defrag.c
> +++ b/fs/ext4/defrag.c
> @@ -632,8 +632,9 @@ static int ext4_ext_defrag_victim(struct file *target_filp,
> }
>
> /* Sync journal blocks before reservation */
> - if (do_fsync(target_filp, 0)) {
> - printk(KERN_ERR "defrag: failed do_fsync\n");
> + ret = ext4_force_commit(sb);
> + if (ret) {
> + printk(KERN_ERR "defrag: failed do_fsync (%d)\n", ret);
I'd think you'd want to change the printk text as well. "defrag: failed
ext4_force_commit (%d)\n" maybe?
> goto ERR;
> }
> }
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2008-01-23 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 13:55 ext4-online-defrag-free-space-fragmentation.patch uses do_fsync() Theodore Ts'o
2008-01-23 14:10 ` Dave Kleikamp [this message]
2008-01-23 14:16 ` Theodore Tso
2008-01-24 3:00 ` Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201097420.9082.5.camel@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=t-sato@yk.jp.nec.com \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox