public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Girish Shilamkar <Girish.Shilamkar@Sun.COM>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix commit block write in JBD2
Date: Thu, 24 Jan 2008 02:48:41 +0530	[thread overview]
Message-ID: <1201123121.3706.9.camel@alpha.linsyssoft.com> (raw)
In-Reply-To: <20080123191054.GH10144@duck.suse.cz>

Hi,
	The loop was removed in journal checksum patch. There had been a
discussion (11 Jul 2007: [EXT4 set 8][PATCH 1/1]Add journal checksums)
about this part of code as checksum info was added to commit block. 

Regards,
Girish
On Wed, 2008-01-23 at 20:10 +0100, Jan Kara wrote:
> On Wed 23-01-08 20:09:43, Jan Kara wrote:
> >   Hi,
> > 
> >   the patch below fixes preparation of commit block in
> > journal_write_commit_record(). Obviously the bug doesn't really matter
> > since nobody reported it so far but let's cleanup the code... Andrew, could
> > you please queue it up? Thanks.
>   And the same fix for JBD2.
> 
> 									Honza

  reply	other threads:[~2008-01-23 21:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 19:09 [PATCH] Fix commit block write in JBD Jan Kara
2008-01-23 19:10 ` [PATCH] Fix commit block write in JBD2 Jan Kara
2008-01-23 21:18   ` Girish Shilamkar [this message]
2008-01-23 22:01     ` Jan Kara
2008-01-27  6:02 ` [PATCH] Fix commit block write in JBD Andrew Morton
2008-01-28 13:18   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201123121.3706.9.camel@alpha.linsyssoft.com \
    --to=girish.shilamkar@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox