public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Shanahan <kmshanah@ucwb.org.au>
To: Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org, Andreas Gruenbacher <agruen@suse.de>,
	bugme-daemon@bugzilla.kernel.org, Theodore Ts'o <tytso@mit.edu>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Bug 9855] ext3 ACL corruption
Date: Tue, 05 Feb 2008 19:12:26 +1030	[thread overview]
Message-ID: <1202200946.4280.4.camel@kulgan.wumi.org.au> (raw)
In-Reply-To: <20080205010617.GL23836@webber.adilger.int>

On Mon, 2008-02-04 at 18:06 -0700, Andreas Dilger wrote:
> Hmm, I wonder if e2fsck is calculating the wrong file offset or something?
> The kernel appears to be taking the EA data offset from the end of
> i_extra_isize and the ext3_xattr_ibody_header fields (so 0x88 + e_value_offs
> from the start of the inode).
> 
> Conversely, debugfs isn't having any problem with this EA at all.
> 
> h, I think I see the problem, and this was fixed in newer e2fsck.
> The EAs are stored "out of order" in the inode and older e2fsprogs
> considered that an error.  That was fixed in the final 1.40 release:
> 
> 	Remove check in e2fsck which requires EA's in inodes to be sorted;
> 	they don't need to be sorted, and e2fsck was previously wrongly
> 	clearing unsorted EA's stored in the inode structure.

Ah, I think you got it! I've just now reproduced the problem on one
filesystem with the old e2fsck-1.40-WIP from Debian Etch and then
checked again with the newer e2fsck-1.40.5 from Sid. The new version
doesn't report any problems.

Thanks very much for your time looking into this.

Regards,
Kevin.

      reply	other threads:[~2008-02-05  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1201771074.4480.2.camel@kulgan.wumi.org.au>
     [not found] ` <20080131100539.GQ23836@webber.adilger.int>
2008-01-31 12:14   ` [Bug 9855] ext3 ACL corruption Kevin Shanahan
2008-02-05  1:06     ` Andreas Dilger
2008-02-05  8:42       ` Kevin Shanahan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202200946.4280.4.camel@kulgan.wumi.org.au \
    --to=kmshanah@ucwb.org.au \
    --cc=adilger@sun.com \
    --cc=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox