Re: BUG with delayed allocation

[Mingming Cao <cmm@us.ibm.com>]

On Thu, 2008-03-20 at 11:09 +0530, Aneesh Kumar K.V wrote:

> > Could you try the following patch? It updates the i_disksize at the
> > write_end time.
> > 
> 
> I will test the patch and update you. BTW shouldn't we update
> i_disksize only after actual block got allocated ?
> 
> 
Hmm...I am not  100% sure but I think we should not to change the
behavior that the on-disk inode size should be updated when write()
returns to user. Right now the in-memory inode size is updated, user
would expecting the same when they run e2fsck, but e2fsck reads inode
size from disk. Pushing the inode i_disksize update at the writeout
(allocation) time will cause the window that i_size is different than
the i_disksize being enlarged quite big.

Mingming
> > 
> > Signed-off-by: Mingming Cao <cmm@us.ibm.com>
> > ---
> >  fs/ext4/inode.c |   39 ++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 38 insertions(+), 1 deletion(-)
> > 
> > Index: linux-2.6.25-rc5/fs/ext4/inode.c
> > ===================================================================
> > --- linux-2.6.25-rc5.orig/fs/ext4/inode.c	2008-03-19 17:32:44.000000000 -0700
> > +++ linux-2.6.25-rc5/fs/ext4/inode.c	2008-03-19 17:43:19.000000000 -0700
> > @@ -1355,6 +1355,43 @@ static int ext4_writeback_write_end(stru
> >  	return ret ? ret : copied;
> >  }
> > 
> > +static int ext4_da_write_end(struct file *file,
> > +				struct address_space *mapping,
> > +				loff_t pos, unsigned len, unsigned copied,
> > +				struct page *page, void *fsdata)
> > +{
> > +	handle_t *handle;
> > +	struct inode *inode = file->f_mapping->host;
> > +	int needed_blocks = ext4_writepage_trans_blocks(inode);
> > +	int ret = 0, ret2;
> > +	loff_t new_i_size;
> > +
> > +	handle = ext4_journal_start(inode, needed_blocks);
> > +	if (IS_ERR(handle)) {
> > +		unlock_page(page);
> > +		page_cache_release(page);
> > +		ret = PTR_ERR(handle);
> > +		return ret;
> > +	}
> > +
> > +	new_i_size = pos + copied;
> > +	if (new_i_size > EXT4_I(inode)->i_disksize)
> > +		EXT4_I(inode)->i_disksize = new_i_size;
> > +
> > +	copied = ext4_generic_write_end(file, mapping, pos, len, copied,
> > +							page, fsdata);
> > +	if (copied < 0)
> > +		ret = copied;
> > +
> > +	ret2 = ext4_journal_stop(handle);
> > +	if (!ret)
> > +		ret = ret2;
> > +	unlock_page(page);
> > +	page_cache_release(page);
> > +
> > +	return ret ? ret : copied;
> > +}
> > +
> >  static int ext4_journalled_write_end(struct file *file,
> >  				struct address_space *mapping,
> >  				loff_t pos, unsigned len, unsigned copied,
> > @@ -2020,7 +2057,7 @@ static const struct address_space_operat
> >  	.writepages	= ext4_da_writepages,
> >  	.sync_page	= block_sync_page,
> >  	.write_begin	= ext4_da_write_begin,
> > -	.write_end	= generic_write_end,
> > +	.write_end	= ext4_da_write_end,
> >  	.bmap		= ext4_bmap,
> >  	.invalidatepage	= ext4_da_invalidatepage,
> >  	.releasepage	= ext4_releasepage,
> > 
> > 
> 
> -aneesh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html