* Entries in feature_list[]
@ 2008-03-27 7:40 Girish Shilamkar
2008-04-13 3:49 ` Andreas Dilger
0 siblings, 1 reply; 2+ messages in thread
From: Girish Shilamkar @ 2008-03-27 7:40 UTC (permalink / raw)
To: Ext4 Mailing List; +Cc: Theodore Tso
Hi,
In e2fsprogs/lib/e2p/feature.c
struct feature feature_list[] contains:
...
{ E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
"extents" },
{ E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
"meta_bg" }
{ E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
"extent" },
...
Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
{E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be
correct feature ?
Thanks,
Girish
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Entries in feature_list[]
2008-03-27 7:40 Entries in feature_list[] Girish Shilamkar
@ 2008-04-13 3:49 ` Andreas Dilger
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Dilger @ 2008-04-13 3:49 UTC (permalink / raw)
To: Girish Shilamkar; +Cc: Ext4 Mailing List, Theodore Tso
On Mar 27, 2008 13:10 +0530, Girish Shilamkar wrote:
> In e2fsprogs/lib/e2p/feature.c
> struct feature feature_list[] contains:
> ...
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extents" },
> { E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
> "meta_bg" }
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extent" },
> ...
>
> Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
> {E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be
> correct feature ?
This is probably a merge error, or maybe a convenice measure to allow both
"extent" and "extents"? We need something similar for "uninit_groups"
and the new "uninit_bg".
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-13 3:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-27 7:40 Entries in feature_list[] Girish Shilamkar
2008-04-13 3:49 ` Andreas Dilger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).