From: Mingming Cao <cmm@us.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: ext4 lock ordering patch
Date: Wed, 28 May 2008 14:08:42 -0700 [thread overview]
Message-ID: <1212008922.3791.34.camel@localhost.localdomain> (raw)
In-Reply-To: <20080526173452.GL32407@duck.suse.cz>
On Mon, 2008-05-26 at 19:34 +0200, Jan Kara wrote:
> Hi Mingming,
>
Hi Jan,
> I've noticed you removed the patch reversing locking order of page lock
> and transaction start from ext4 patch queue. Was this because of that
> reported performance problem or for some other reason? As far as I've
> understood that problem has been just in the patch fixing the delalloc mode
> part so just removing that patch would be enough AFAICT.
It was because of the reverse locking handling for delayed allocation.
But we can't just drop the patch fixing the locking order in delalloc
mode part only, we need to drop the whole delalloc or drop the whole
inverse locking patches.
> Anyway, the problem is I have now ordered mode rewrite for JBD2/ext4
> which depends on this patch so the question is how to proceed... Should we
> first fix that delalloc problem (are you looking into that?) or do we merge
> all the changes and then fixup the delalloc code?
>
Aneesh is close to getting lock reserve fixed for delalloc... Let's see.
If that takes too long I think it make sense to merge the new ordered
mode rewrite first then re-think of the delalloc solution based on
reversed locking (rather than fixing around) and the new ordered mode.
Mingming
prev parent reply other threads:[~2008-05-28 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 17:34 ext4 lock ordering patch Jan Kara
2008-05-26 17:51 ` Aneesh Kumar K.V
2008-05-27 12:13 ` Jan Kara
2008-05-28 21:08 ` Mingming Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212008922.3791.34.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox